-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add testid to the components in Channel #1089
refactor: Add testid to the components in Channel #1089
Conversation
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f152fac
to
c5e31c2
Compare
src/modules/GroupChannel/components/FileViewer/FileViewerView.tsx
Outdated
Show resolved
Hide resolved
src/ui/ReactionButton/__tests__/__snapshots__/ReactionButton.spec.js.snap
Outdated
Show resolved
Hide resolved
src/ui/ReactionButton/index.tsx
Outdated
@@ -53,6 +53,7 @@ const ReactionButton = React.forwardRef((props: ReactionButtonProps, ref: Forwar | |||
{...onClickHandler} | |||
tabIndex={0} | |||
data-sb-id={dataSbId} | |||
data-testid={dataSbId} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: 이건 기존에 사용하고있는 dataSbId 가 좀 많아서 이해는 되는 부분인데, 아래의 관점에서 좋은 선택일지 나중에 고민해보시면 좋을것 같아서 코멘트 남깁니다.
- 작성된 testID 와 dataSbId 의 컨벤션 문제 (히스토리를 모르는 개발자가, 나중에 코드를 보았을때 추측을 하게되는 코드는 좋지 않다.
ex: 여긴 왜 다른데랑 다른형식으로 작성이 되어있지?
) - 새롭게 추가되는 인터페이스에, 앞으로 제거할 레거시를 이어가는것이 좋은 선택인지 (
ex: 여러번의 메이저 버전을 넘어오는 과정에서 이러한 선택이 없었는지, 있었다면 다음 메이저 버전에서 개선을 했었는지, 개선을 했다면 어떤 방식으로 이 태스크를 챙겼는지 등.. 과거에서 되돌아 볼 수 있음
)
Do you have a ticket for this? |
@HoonBaek Please resolve conflicts |
df970c3
to
78f3551
Compare
I attach the ticket link and resolve the conflict, pls review it again @bang9 |
edeaf7e
to
6731e94
Compare
@@ -19,14 +19,19 @@ export interface MenuItemProps { | |||
children: ReactElement | ReactElement[] | ReactNode; | |||
onClick?: (e: MouseEvent<HTMLLIElement>) => void; | |||
disable?: boolean; | |||
/** | |||
* @deprecated Please use the testID instead | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CLNP-2666
Added
data-testid
to the UI components for making it easily to select them in the QE test