feat: Support welcome messages #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcho
force-pushed
the
feat/AC-2362-support-welcome-messages
branch
from
8ed8443
to
5a88be7
Compare
bang9
reviewed
May 17, 2024
bang9
reviewed
May 17, 2024
src/modules/GroupChannel/components/GroupChannelUI/GroupChannelUIView.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 17, 2024
src/modules/GroupChannel/components/GroupChannelUI/GroupChannelUIView.tsx
Outdated
Show resolved
Hide resolved
…lement when expecting ReactElement. bumping version fixed it.
bang9
reviewed
May 17, 2024
bang9
reviewed
May 17, 2024
bang9
reviewed
May 17, 2024
bang9
reviewed
May 17, 2024
bang9
approved these changes
May 20, 2024
liamcho
added a commit
that referenced
this pull request
May 27, 2024
Fixes: [AC-2362](https://sendbird.atlassian.net/browse/AC-2362) - Added `renderWelcomeMessage ` to `GroupChannelUIBasicProps` - Widget wants to draw custom welcome message in message list but at the same time remove actual/original welcome messages in message list. `renderWelcomeMessage` allows to draw custom welcome messages. Unwanted Message can be filtered using `renderMessage`. [AC-2362]: https://sendbird.atlassian.net/browse/AC-2362?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
liamcho
added a commit
that referenced
this pull request
May 27, 2024
Fixes: [AC-2362](https://sendbird.atlassian.net/browse/AC-2362) - Added `renderWelcomeMessage ` to `GroupChannelUIBasicProps` - Widget wants to draw custom welcome message in message list but at the same time remove actual/original welcome messages in message list. `renderWelcomeMessage` allows to draw custom welcome messages. Unwanted Message can be filtered using `renderMessage`. [AC-2362]: https://sendbird.atlassian.net/browse/AC-2362?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Hyungu Kang | Airen <gusrn1423@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: AC-2362
Changelogs
renderWelcomeMessagetoGroupChannelUIBasicPropsWhy?
renderWelcomeMessageallows to draw custom welcome messages. Unwanted Message can be filtered usingrenderMessage.