Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a SHA1 tutorial with modules #827

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

bcm-at-zama
Copy link
Contributor

@bcm-at-zama bcm-at-zama commented May 15, 2024

Adding a SHA1 implementation, using Modules.

This .py will also be very useful to test Modules with non-v0 parameters.

closes https://github.com/zama-ai/concrete-internal/issues/711

@cla-bot cla-bot bot added the cla-signed label May 15, 2024
@bcm-at-zama bcm-at-zama marked this pull request as draft May 15, 2024 11:40
@bcm-at-zama bcm-at-zama force-pushed the sha1_module_tutorial_711 branch 13 times, most recently from 3120708 to 7503dcf Compare May 15, 2024 13:56
@bcm-at-zama
Copy link
Contributor Author

@aPere3 @BourgerieQuentin : do you want to have a look to this notebook and .md?

@bcm-at-zama bcm-at-zama marked this pull request as ready for review May 15, 2024 13:58
@bcm-at-zama bcm-at-zama changed the title Adding a SHA1 tutorial with modules [WIP] Adding a SHA1 tutorial with modules May 15, 2024
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
@bcm-at-zama bcm-at-zama force-pushed the sha1_module_tutorial_711 branch 5 times, most recently from 55c1165 to 7a471f2 Compare May 22, 2024 12:40
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
@BourgerieQuentin
Copy link
Member

and maybe a pass by @yuxizama could be good

@bcm-at-zama
Copy link
Contributor Author

Thx. Yes we'll have Yuxi make a review but let me first make your proposed changes.

@yuxizama
Copy link
Contributor

Will have a look this afternoon

@bcm-at-zama
Copy link
Contributor Author

Will have a look this afternoon

if I were you, I would wait a bit, since more changes are expected

@bcm-at-zama
Copy link
Contributor Author

So I stop my experiments about no-module implementation, but they are in #851

@bcm-at-zama
Copy link
Contributor Author

So, first, I propose we let's have it reviewed and approved by @BourgerieQuentin and @aPere3 . Once done, I'll see with @yuxizama

@bcm-at-zama bcm-at-zama marked this pull request as ready for review May 27, 2024 14:16
@bcm-at-zama bcm-at-zama requested a review from aPere3 May 27, 2024 14:16
Copy link
Contributor

@aPere3 aPere3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @bcm-at-zama Thanks !

@bcm-at-zama
Copy link
Contributor Author

Let me fix mypy

@bcm-at-zama
Copy link
Contributor Author

the CI looks green, or at least ruff and mypy.

@bcm-at-zama
Copy link
Contributor Author

@yuxizama , we're ready now, content wise. Do you want to have a look now? Certainly we could also add a link from our https://docs.zama.ai/concrete/compilation/modules to this new tutorial

Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys, I proposed some changes on the language.
Thanks!

frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing most of the comments by @yuxizama

frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
frontends/concrete-python/examples/sha1/sha1.md Outdated Show resolved Hide resolved
@bcm-at-zama bcm-at-zama requested a review from yuxizama May 28, 2024 08:59
Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed two comments.
Besides that all good to me!

@bcm-at-zama
Copy link
Contributor Author

Let me squash that

@bcm-at-zama
Copy link
Contributor Author

Fine to merge that for me, @BourgerieQuentin

@BourgerieQuentin BourgerieQuentin merged commit 226ee27 into main May 31, 2024
28 checks passed
@BourgerieQuentin BourgerieQuentin deleted the sha1_module_tutorial_711 branch May 31, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants