Am/feat/updated ntt pbs #1093
Open
Am/feat/updated ntt pbs #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
changed the base branch from
main
to
am/refactor/non-native-decomposer
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
from
119ab87
to
fad081b
Compare
mayeul-zama
reviewed
Apr 22, 2024
IceTDrinker
force-pushed
the
am/refactor/non-native-decomposer
branch
from
56d36d3
to
4717006
Compare
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
from
fad081b
to
1afa8d5
Compare
IceTDrinker
force-pushed
the
am/refactor/non-native-decomposer
branch
from
4717006
to
2f4c72d
Compare
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
2 times, most recently
from
3488b83
to
61d816e
Compare
IceTDrinker
force-pushed
the
am/refactor/non-native-decomposer
branch
from
2f4c72d
to
27af2a9
Compare
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
from
61d816e
to
61ede17
Compare
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
3 times, most recently
from
494794a
to
e355217
Compare
mayeul-zama
reviewed
May 22, 2024
mayeul-zama
reviewed
May 22, 2024
tfhe/src/core_crypto/algorithms/lwe_programmable_bootstrapping/ntt64.rs
Outdated
Show resolved
Hide resolved
- use size primitives in places where it makes sense
Co-authored-by: sarah el kazdadi <sarah.elkazdadi@zama.ai>
…_ceil - use div_ceil instead of doing it manually in parallel FFT conversion
…lgos - update GLWE and GGSW encryption algorithms
Co-authored-by: sarah el kazdadi <sarah.elkazdadi@zama.ai>
Co-authored-by: sarah el kazdadi <sarah.elkazdadi@zama.ai>
- also add docstrings to ntt primitives - export a now useful functions for decryption on non native moduli
- some code was repeated several times, factorize it out in a function
IceTDrinker
force-pushed
the
am/feat/updated-ntt-pbs
branch
from
e355217
to
70fbfbf
Compare
|
looks good to me as well |
sarah-ek
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/zama-ai/tfhe-rs-internal/issues/531
This is currently in draft as it's missing some docstrings and doctests, the rest should be mostly ready, you can likely check commit by commit to avoid being swamped by some refactors I did (notably splitting the lwe programmable bootstrap file depending on which poly mul backend we use)
I am not exposing the CMUX and ext prod for now