refactor(tfhe): Allow CompactCiphertextList to store heterogeneous types #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
force-pushed
the
tm/better-compact-list
branch
4 times, most recently
from
c8993a1
to
762507b
Compare
tmontaigu
force-pushed
the
tm/better-compact-list
branch
3 times, most recently
from
75ef4d0
to
88fb777
Compare
tmontaigu
force-pushed
the
tm/better-compact-list
branch
from
88fb777
to
43ba08a
Compare
tmontaigu
force-pushed
the
tm/better-compact-list
branch
2 times, most recently
from
599dcb1
to
2e90e06
Compare
tmontaigu
force-pushed
the
tm/better-compact-list
branch
4 times, most recently
from
c2046ee
to
b71527c
Compare
IceTDrinker
reviewed
May 28, 2024
IceTDrinker
reviewed
May 30, 2024
IceTDrinker
reviewed
May 31, 2024
tmontaigu
force-pushed
the
tm/better-compact-list
branch
from
5e1df0a
to
8686eb4
Compare
This refactors the integer's CompactCiphertextList to allow storing
unsigned, signed (without necessarily the same number of blocks) and
booleans in a single comapct list.
This is better as its more flexible and allows for better compression
by not forcing to use a list per data type. This is especially
interessing with zero-knowledge proofs as they are expensive to compute.
This also adds the ability to pack integer blocks by using the carry
space, but makes the expansion require a ServerKey to split blocks
via PBS.
BREAKING CHANGE: expand method from CompactCiphertextList returns a
CiphertextExpander
BREAKING CHANGE: Removes 'typed' CompactList and Compact types from the hlapi
(e.g. CompactFheUintList/CompactFheUintX)
tmontaigu
force-pushed
the
tm/better-compact-list
branch
from
8686eb4
to
ebcb65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the integer's CompactCiphertextList to allow storing usngined, signed (not with necessarily the same number of blocks) and booleans in a single comapct list.
This is better as its more flexible and allows for better compression by not forcing to use a list per data type. This is especially interessing with zero-knowledge proofs as they are expensive to compute.
This also removes 'typed' CompactList and Comapct types from the hlapi.