Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test #129

wants to merge 3 commits into from

Conversation

feefladder
Copy link
Contributor

@feefladder feefladder commented Feb 8, 2023

working!
Only tests on linux using barichello container and no shell scripts. I also changed the mainscene to the demo, but can revert that in a future commit.

@feefladder
Copy link
Contributor Author

@2shady4u It's working now!
I could also add more tests, like convert the basic_querying function to tests?
Then I think it'd be nicest to merge this and I can open a second PR?

@2shady4u
Copy link
Owner

@2shady4u It's working now! I could also add more tests, like convert the basic_querying function to tests? Then I think it'd be nicest to merge this and I can open a second PR?

Good job @feefladder 😄

For now I would propose to just have the single open/close test.
The main goal of this PR was to figure out #122

Thus, the real fun begins: Changing the host platform to "macos-11" and seeing what happens 😆

@2shady4u 2shady4u force-pushed the master branch 6 times, most recently from 0559134 to f31d1ff Compare January 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants