Add support for macOS #615

kevindurb · 2023-02-07T18:02:18Z

This gets the installer working on macos systems, you still need to brew install coreutils so we might want to add that to the README.md

This also changes mounting of volumes for macos only to skip /, /dev, /tmp, /sys and changes the user home mount to be a "regular" shared mount rather than rslave

…s systems)

…op doesnt support bind-propagation

drewmoseley · 2023-02-07T22:01:37Z

Trying this branch on my M1 MacBook Air using colima results in:

$ distrobox create
Image registry.fedoraproject.org/fedora-toolbox:36 not found.
Do you want to pull the image now? [Y/n]: y
36: Pulling from fedora-toolbox
79ccb8138384: Pull complete
b58c382a31cf: Pull complete
Digest: sha256:48aab1f04aa02b0a7a1f1aabfde1ba9908686e08a43123bd34fe966f15c47dab
Status: Downloaded newer image for registry.fedoraproject.org/fedora-toolbox:36
registry.fedoraproject.org/fedora-toolbox:36
Creating 'my-distrobox' using image registry.fedoraproject.org/fedora-toolbox:36	 [ OK ]
Distrobox 'my-distrobox' successfully created.
To enter, run:

distrobox enter my-distrobox

Error response from daemon: mount /etc/localtime:/var/lib/docker/overlay2/b376c5aa8df3a346fa74220efc29dda6d881c9a80de9b83e432fc26a9dabed33/merged/usr/share/zoneinfo/Etc/UTC, flags: 0x5001: not a directory

Using it with docker-desktop, it seems that the distrobox is not created when distrobox-create exits. I view the logs of the container and it continues installing packages and such for some time. I'm not sure if that is normal. But if I let that run to what appears to be completion (ie I see "container_setup_done" in the container logs), then I get the following:

$ distrobox enter my-distrobox
OCI runtime exec failed: exec failed: unable to start container process: chdir to cwd ("/run/host/work/dmoseley/distrobox") set in config.json failed: no such file or directory: unknown

kevindurb · 2023-02-07T22:24:58Z

Are you running with the experimental virtio and rosetta 2 support? I think those are gonna be key in getting io and cpu performant enough to make this viable, without them my enter errors out as well

kevindurb · 2023-02-07T22:25:36Z

Not sure about lima :(

drewmoseley · 2023-02-09T14:41:59Z

I just enabled virtio and rosetta2 support but the behavior was the same for me.

kevindurb · 2023-02-09T22:29:58Z

hmm weird, just reset my settings and tried creating the fedora toolbox image and it works great for me. it does take a couple minutes to start up so i had to run distrobox enter... a couple times before it finally dropped me in

89luca89 · 2023-02-10T15:51:13Z

distrobox-create

+			--volume \"${distrobox_export_path}\":/usr/bin/distrobox-export:ro
+			--volume \"${distrobox_hostexec_path}\":/usr/bin/distrobox-host-exec:ro
+			--volume \"${container_user_home}\":\"${container_user_home}\":rslave"
+	fi



--volume \"${distrobox_entrypoint_path}\":/usr/bin/entrypoint:ro --volume \"${distrobox_export_path}\":/usr/bin/distrobox-export:ro --volume \"${distrobox_hostexec_path}\":/usr/bin/distrobox-host-exec:ro

is the same for both cases, so maybe you can move them to line 468?

89luca89 · 2023-02-10T15:52:02Z

install

+	else
+		install $@
+	fi
+}


POSIX install should work why specifically use gnu install?

The problem is the -D flag isn’t present in macOS’s install.

https://apple.stackexchange.com/questions/201029/install-illegal-option-d

I’m not familiar with which flags are required by POSIX.

@89luca89 Actually, it looks like install is not part of POSIX unfortunately.

The command is not defined in POSIX. It has mostly split into two camps in terms of compatibility, a GNU type and a BSD type. The main incompatibility lies in the definition of options -D and -d.

https://en.wikipedia.org/wiki/Install_(Unix)

Luckily, we can just add coreutils as a build dependency. It would easier to make brew install distrobox the main way to install distrobox on macOS. There's already a forumla at distrobox.rb.

It only needs slight modifications (removing depends_on :linux and adding coreutils as a dependency for macOS). I have the installer working on my Intel-based macOS just via brew install coreutils and then adding the GNU commands earlier in my PATH. Here is why:

~ $ install -D install: illegal option -- D usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode] [-o owner] file1 file2 install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode] [-o owner] file1 ... fileN directory install -d [-v] [-g group] [-m mode] [-o owner] directory ... ~ $ /usr/local/opt/coreutils/libexec/gnubin/install -D ginstall: missing file operand Try 'ginstall --help' for more information.

It is easier to implement to use ginstall directly, though:

~ $ ginstall -D ginstall: missing file operand Try 'ginstall --help' for more information. ~ $

I'm currently working on getting brew install distrobox to fully work out of the box on Linux (Homebrew/homebrew-core#135178). This should hopefully aid in porting basic features to macOS (Homebrew/discussions#4603).

The way I currently simulate distrobox enter on macOS is very bare-bones and depends on manually creating and renaming the containers. I can learn from the way distrobox create does it and write my own scripts, but porting distrobox to macOS would benefit more people.

#!/usr/bin/env bash # Usage: my-distrobox-enter <name> # # Note: You kinda have to create the container first # 1. podman run -it homebrew/brew # 2. open -a "Podman Desktop" # Find the name # 3. podman rename suspicious_wozniak brew # Debugging set -ex # Start the podman machine (VM) if needed podman machine start || true # Start the container if needed podman start "$1" # Profit podman exec -it "$1" bash

I’m not sure why my replies are marked “Pending” and they seem not visible

Edit: I figured it out thx to https://github.com/orgs/community/discussions/10369

install

@@ -82,6 +82,14 @@
 icon_dest_path="${prefix}/share/icons"
 completion_dest_path="${prefix}/share/bash-completion/completions/"

+install_command() {
+	if [ "$(uname)" == "Darwin" ]; then
+		ginstall $@


install

+	if [ "$(uname)" == "Darwin" ]; then
+		ginstall $@
+	else
+		install $@


distrobox-create

-		--volume \"${distrobox_export_path}\":/usr/bin/distrobox-export:ro
-		--volume \"${distrobox_hostexec_path}\":/usr/bin/distrobox-host-exec:ro
-		--volume \"${container_user_home}\":\"${container_user_home}\":rslave"
+	if [ "$(uname)" == "Darwin" ]; then


install

@@ -82,6 +82,14 @@
 icon_dest_path="${prefix}/share/icons"
 completion_dest_path="${prefix}/share/bash-completion/completions/"

+install_command() {
+	if [ "$(uname)" == "Darwin" ]; then


89luca89 · 2023-02-10T15:53:41Z

Hi @kevindurb glad to see work is being done on this! 😄

Hopefully I can find some mac where to test this stuff 👀

I've left a couple of comments, and some linting stuff to do, will try to also create a macos VM where to test all of this

pythoninthegrass · 2023-03-02T23:50:29Z

Hi @kevindurb glad to see work is being done on this! 😄

Hopefully I can find some mac where to test this stuff 👀

I've left a couple of comments, and some linting stuff to do, will try to also create a macos VM where to test all of this

@89luca89 Would you be able to work off of an x86 2017 MacBook Air? I might be able to acquire one from work and ship it to you. If not, I'd be happy to test on any of my Macs; I have access to x86 and arm64 Apple laptops and one x86 mini.

I'd even be willing to setup a GitHub Actions runner to do the same if it's possible to test in CI.

Would love to see this get spearheaded for testing ephemeral Mac instances the same way I do with Linux 🙌

89luca89 · 2023-03-09T18:03:18Z

@89luca89 Would you be able to work off of an x86 2017 MacBook Air? I might be able to acquire one from work and ship it to you. If not, I'd be happy to test on any of my Macs; I have access to x86 and arm64 Apple laptops and one x86 mini.

Thanks for the offer but I'd prefer not to accept, that would be too much :)

But if anyone knows If there are any services online that can (legally) give you access to a remote Macos VM (where I can also run lima and docker-desktop) that can help

pythoninthegrass · 2023-03-09T18:29:20Z

No worries!

Looks like you've got HostMyApple (HMA), MacInCloud (MIC), and MacStadium. Latter is the most spendy for bare metal at $119/mo; they don't advertise the virtualized instance prices.

Former two are both $25/mo. HMA is a VM, MIC is bare metal.

If you setup a GitHub Sponsorship, can chip in for any of the above.

89luca89 · 2023-03-09T18:49:23Z

No worries!

Looks like you've got HostMyApple (HMA), MacInCloud (MIC), and MacStadium. Latter is the most spendy for bare metal at $119/mo; they don't advertise the virtualized instance prices.

Former two are both $25/mo. HMA is a VM, MIC is bare metal.

If you setup a GitHub Sponsorship, can chip in for any of the above.

Will take a look at them thanks a lot! :)

FedX-sudo · 2023-04-07T14:38:04Z

Hi, I see that this was built with Docker Desktop in mind. However, Podman is supported on MacOS as well, and I was wondering if you have been able to test this with Podman. I am trying to spin up a MacOS VM to test this but I don't exactly have convenient access to a Mac either!

FedX-sudo · 2023-04-08T02:02:08Z

I don't see a reference to ginstall in Brew. What's that package?

kevindurb · 2023-04-17T14:29:17Z

@FedX-sudo brew install coreutils and i couldnt get podman working, mounting all of home inside the vm ends up crashing podman. I assume podman would need macos virtio fs support like docker desktop has

ericcurtin · 2023-04-27T09:22:38Z

Highly recommend podman desktop backend for this on macOS, just saying... https://podman-desktop.io/downloads

osalbahr · 2023-06-19T18:50:35Z

Just stumbled across this PR. I have an Intel-based MacBook Pro. Is there anything I can help with?

almereyda · 2023-06-21T16:31:06Z

Running ./install on this branch with colima on a Mac Book Air M1 currently yields this error:

% distrobox create --image registry.fedoraproject.org/fedora-toolbox:37 --name fedorabox
Image registry.fedoraproject.org/fedora-toolbox:37 not found.
Do you want to pull the image now? [Y/n]:
37: Pulling from fedora-toolbox
dcee36d2eab5: Pull complete
fef687da97fd: Pull complete
Digest: sha256:5145e00e875a45d7b468bb2eb662c30c7b7d408096fd4a76924119f8bfbb3712
Status: Downloaded newer image for registry.fedoraproject.org/fedora-toolbox:37
registry.fedoraproject.org/fedora-toolbox:37
Creating 'fedorabox' using image registry.fedoraproject.org/fedora-toolbox:37    [ OK ]
Distrobox 'fedorabox' successfully created.
To enter, run:

distrobox enter fedorabox

Error response from daemon: mount /etc/localtime:/var/lib/docker/overlay2/6ee806a0e2392482c10e731dda1ded6e715393805d79e95b50ffdf8daecb8677/merged/usr/share/zoneinfo/Etc/UTC, flags: 0x5001: not a directory

Trying to enter that distrobox then yields:

% distrobox enter fedorabox
Container fedorabox is not running.
Starting container fedorabox
run this command to follow along:

 docker logs -f fedorabox

Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/etc/localtime" to rootfs at "/etc/localtime": mount /etc/localtime:/etc/localtime (via /proc/self/fd/6), flags: 0x5001: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
Error: failed to start containers: fedorabox

Should this branch be rebased against main, and we test again to create a working and documented Distrobox environment for (ARM) Macs?

osalbahr · 2023-06-25T13:36:22Z

Is there a reason this PR was drafted? I'd love to help port distrobox to macOS

almereyda · 2023-06-28T17:25:12Z

Could you check out this branch and try it out locally, in so we can improve on the remaining issues together? I would be interested in seeing how far you get in trying to get it to work.

There's this /etc/localtime mount error, where it stopped for me, and I suspect there would be other mounts failing, if that one passed.

osalbahr · 2023-06-28T17:28:12Z

Could you check out this branch and try it out locally, in so we can improve on the remaining issues together? I would be interested in seeing how far you get in trying to get it to work.

There's this /etc/localtime mount error, where it stopped for me, and I suspect there would be other mounts failing, if that one passed.

I’d be interested in collaborating on a PR, if there’s interest in officially maintaining it! It’s up to @89luca89 (and other maintainers) if it’s worth the effort.

Feel free to @ me if this PR re-opens or there’s another open PR. Also, I think small bite-sized incremental support is better than one big PR. Like, one only for the install (and maybe some clarifying documentation that it’s in beta, we can also add a caveat to the brew formula).

redthing1 · 2023-08-15T07:17:24Z

I would be interested in helping as well.

redthing1 · 2023-08-16T06:04:41Z

Having this issue:

❯ distrobox create --image fedora
Image fedora not found.
Do you want to pull the image now? [Y/n]:
Resolved "fedora" as an alias (/etc/containers/registries.conf.d/000-shortnames.conf)
Trying to pull registry.fedoraproject.org/fedora:latest...
Getting image source signatures
Copying blob sha256:b515bb6817bb5717be9fa1a4e838bcc307d1278ead65a4a80f268661fcb77b44
Copying config sha256:a831f8cb3d2be39ecc55228b3a6a29a23d83f35ec18143d6441a22df67ede8cc
Writing manifest to image destination
a831f8cb3d2be39ecc55228b3a6a29a23d83f35ec18143d6441a22df67ede8cc
Creating 'fedora' using image fedora Error: statfs /usr/local/bin/distrobox-export: no such file or directory

ericcurtin · 2023-08-16T08:48:07Z

@redthing1 looks like you got pretty far to be honest, it would be interesting to see:

uname -a
cat /etc/*release

output there.

If you manually copy in a distrobox-export to /usr/local/bin/distrobox-export ... You might get further?

ericcurtin · 2023-08-16T08:49:35Z

By the way Fedora Asahi Remix aka Asahi Linux:

https://asahilinux.org/2023/08/fedora-asahi-remix/

works out the box for distrobox, if you want to install Linux on your Apple Silicon system and run distrobox that way.

89luca89 · 2023-08-16T08:55:31Z

I think the problem relies on how distrobox mounts some of its own stuff into the container, so probably one needs to
copy distrobox also in the container for it to be able to mount itself

I'm not sure after that how much integration would work having a VM as middleman
I doubt that sound, graphics and devices integration will work

And at that point, you may as well use a regular podman/docker container

redthing1 · 2023-08-19T16:10:51Z

I think the problem relies on how distrobox mounts some of its own stuff into the container, so probably one needs to copy distrobox also in the container for it to be able to mount itself

I'm not sure after that how much integration would work having a VM as middleman I doubt that sound, graphics and devices integration will work

And at that point, you may as well use a regular podman/docker container

Yeah, I'm currently working on a minimalist implementation of this that provides a more abstracted/automated CLI for macOS. If anyone else is interested, let me know and I'll share it

install: update installer to use ginstall if uname == Darwin (on maco…

0b52ffd

…s systems)

kevindurb mentioned this pull request Feb 7, 2023

[Feature] MacOS host support #36

Open

kevindurb added 2 commits February 7, 2023 11:35

install: fix formatting with shfmt

a162d8c

create: Dont mount /, /dev, /sys or /tmp for macos since docker deskt…

6012f53

…op doesnt support bind-propagation

kevindurb changed the title ~~install: update installer to use ginstall if on macos~~ Add support for macOS Feb 7, 2023

create: fix indentation to match tabs rather than spaces

e52f623

89luca89 requested changes Feb 10, 2023

View reviewed changes

github-advanced-security bot found potential problems Feb 10, 2023

View reviewed changes

89luca89 force-pushed the main branch 3 times, most recently from 85306b9 to 8b31dc4 Compare March 26, 2023 14:14

89luca89 force-pushed the main branch 5 times, most recently from a1c5095 to 2061ce7 Compare June 13, 2023 19:08

89luca89 force-pushed the main branch 4 times, most recently from 615a4b5 to c8ed679 Compare June 15, 2023 07:30

89luca89 marked this pull request as draft June 23, 2023 17:44

89luca89 force-pushed the main branch 3 times, most recently from 6c315c5 to 88e2b5a Compare August 6, 2023 12:27

89luca89 force-pushed the main branch 2 times, most recently from ba8e5e7 to 0c4615b Compare August 26, 2023 12:17

89luca89 force-pushed the main branch 2 times, most recently from 456475a to d065c94 Compare September 24, 2023 21:28

89luca89 force-pushed the main branch 2 times, most recently from cca3514 to 551675e Compare November 19, 2023 15:59

89luca89 force-pushed the main branch 3 times, most recently from c14e010 to a7df145 Compare February 20, 2024 19:59

JamiKettunen mentioned this pull request May 1, 2024

install: use more portable install(1) arguments #1364

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for macOS #615

Add support for macOS #615

kevindurb commented Feb 7, 2023 •

edited

drewmoseley commented Feb 7, 2023

kevindurb commented Feb 7, 2023

kevindurb commented Feb 7, 2023

drewmoseley commented Feb 9, 2023

kevindurb commented Feb 9, 2023

89luca89 Feb 10, 2023

89luca89 Feb 10, 2023

osalbahr Jun 28, 2023

osalbahr Jun 28, 2023

osalbahr Jun 28, 2023

osalbahr Jun 28, 2023 •

edited

89luca89 commented Feb 10, 2023

pythoninthegrass commented Mar 2, 2023

89luca89 commented Mar 9, 2023

pythoninthegrass commented Mar 9, 2023

89luca89 commented Mar 9, 2023

FedX-sudo commented Apr 7, 2023

FedX-sudo commented Apr 8, 2023

kevindurb commented Apr 17, 2023

ericcurtin commented Apr 27, 2023

osalbahr commented Jun 19, 2023

almereyda commented Jun 21, 2023

osalbahr commented Jun 25, 2023

almereyda commented Jun 28, 2023 •

edited

osalbahr commented Jun 28, 2023 •

edited

redthing1 commented Aug 15, 2023

redthing1 commented Aug 16, 2023

ericcurtin commented Aug 16, 2023

ericcurtin commented Aug 16, 2023 •

edited

89luca89 commented Aug 16, 2023

redthing1 commented Aug 19, 2023

Add support for macOS #615

Are you sure you want to change the base?

Add support for macOS #615

Conversation

kevindurb commented Feb 7, 2023 • edited

drewmoseley commented Feb 7, 2023

kevindurb commented Feb 7, 2023

kevindurb commented Feb 7, 2023

drewmoseley commented Feb 9, 2023

kevindurb commented Feb 9, 2023

89luca89 Feb 10, 2023

Choose a reason for hiding this comment

89luca89 Feb 10, 2023

Choose a reason for hiding this comment

osalbahr Jun 28, 2023

Choose a reason for hiding this comment

osalbahr Jun 28, 2023

Choose a reason for hiding this comment

osalbahr Jun 28, 2023

Choose a reason for hiding this comment

osalbahr Jun 28, 2023 • edited

Choose a reason for hiding this comment

89luca89 commented Feb 10, 2023

pythoninthegrass commented Mar 2, 2023

89luca89 commented Mar 9, 2023

pythoninthegrass commented Mar 9, 2023

89luca89 commented Mar 9, 2023

FedX-sudo commented Apr 7, 2023

FedX-sudo commented Apr 8, 2023

kevindurb commented Apr 17, 2023

ericcurtin commented Apr 27, 2023

osalbahr commented Jun 19, 2023

almereyda commented Jun 21, 2023

osalbahr commented Jun 25, 2023

almereyda commented Jun 28, 2023 • edited

osalbahr commented Jun 28, 2023 • edited

redthing1 commented Aug 15, 2023

redthing1 commented Aug 16, 2023

ericcurtin commented Aug 16, 2023

ericcurtin commented Aug 16, 2023 • edited

89luca89 commented Aug 16, 2023

redthing1 commented Aug 19, 2023

kevindurb commented Feb 7, 2023 •

edited

osalbahr Jun 28, 2023 •

edited

almereyda commented Jun 28, 2023 •

edited

osalbahr commented Jun 28, 2023 •

edited

ericcurtin commented Aug 16, 2023 •

edited