Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kasparpeterson/auth #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KasparPeterson
Copy link

@KasparPeterson KasparPeterson commented Nov 27, 2023

Pull Request

Description

Introducing the optional authorisation through the header field. See:

  • schemas/openapi.yml
  • schemas/openapi.json

Checklist

Please review and check the following items to ensure your pull request can be processed smoothly:

  • My code adheres to the project's coding standards and style guidelines.

  • I have tested my changes thoroughly, including unit tests where applicable.

  • I have updated the documentation to reflect any changes made in this pull request.

  • My branch is up-to-date with the latest changes from the main branch.

  • I have received code review feedback and addressed any comments or concerns.

Additional Notes

On the main branch the linting is not working using:

  • prettier . -c
  • eslint . --ext .ts,.tsx

Fixed the prettier issue using prettier . -w but could not fix with the eslint as it broke some of the things already fixed with prettier. My conclusion is that these checks are not working at the same time.

References, Fixes and Closes

List any other pull requests or issues that this pull request references, fixes, or closes, if applicable.

  • References #related_issue_number
  • Fixes #related_issue_number
  • Closes #related_issue_number

@hackgoofer
Copy link
Contributor

hackgoofer commented Nov 28, 2023

Mind fixing the merge conflicts? And remove the reformatting.

@jzanecook jzanecook self-assigned this Nov 28, 2023
@hackgoofer
Copy link
Contributor

hackgoofer commented Jan 9, 2024

  1. Need to add RFC
  2. Resolve build errors
  3. Take out style changes to put that in a separate PR.
  4. Update the Doc

cc: @KasparPeterson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants