Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2.1 #53

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open

Update to v2.1 #53

wants to merge 61 commits into from

Conversation

digitallysavvy
Copy link

Updated Agora VideoUIKit for React Web to use v2.1 of the Agora React SDK.

New web-component without 3rd party libraries to handle wrapping React component as HTML component. New web-component uses Vite instead of CreateReactApp.

@digitallysavvy digitallysavvy added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Apr 16, 2024
@digitallysavvy digitallysavvy self-assigned this Apr 16, 2024
Copy link

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you turn off the camera, the mic gets muted as well

Copy link

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change roles to audience, then come back to host, the camera and mic do not work

Copy link

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have 4+ members the UI doesn't fit within the screen anymore, and expands vertically.

Might not be a UI Kit issue, and just a quirk in the example

@digitallysavvy
Copy link
Author

If you have 4+ members the UI doesn't fit within the screen anymore, and expands vertically.

Might not be a UI Kit issue, and just a quirk in the example

I tested this issue and the UI expands well beyond 4 users.

Screenshot 2024-04-17 at 4 11 35 PM Screenshot 2024-04-17 at 4 15 55 PM

@tadaspetra
Copy link

tadaspetra commented Apr 18, 2024

I tested this issue and the UI expands well beyond 4 users.

Screenshot 2024-04-17 at 4 11 35 PM Screenshot 2024-04-17 at 4 15 55 PM

My comment wasn't really clear here. But you can see in the floating view (the second one) that the blue bottom menu is no longer visible unless you scroll, this only happens when there is 4+ people. At 3, it's still visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants