Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOB] allow the restriction of CORS origins #2825

Open
wants to merge 1 commit into
base: testnet3
Choose a base branch
from

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Nov 7, 2023

Cc @zosorock, as this is probably most applicable to services run atop the REST server.

Finding: TOB-ALEO-23

Signed-off-by: ljedrz <ljedrz@gmail.com>
@vvp
Copy link
Contributor

vvp commented Nov 8, 2023

Alternatively, instead of this PR we could remove the direct CORS support from REST API and let node operators run a reverse proxy for snarkOS in which the CORS is configured (e.g. nginx), if they need it.

This option would simplify our codebase and allow more flexible CORS configurations, but it would also add that extra step and operational overhead when integrating snarkOS into websites via REST (unsure how common use case that'll be).

@howardwu
Copy link
Contributor

This is already guarded using firewalls today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants