Created Install Script for Debian

[fabrinasr]

Motivation

I looked at the Ubuntu script created by Howard and I made one main modification to make it work for Debian. In the Debian repos the LLVM and Clang packages are old. To solve this issue I grabbed the LLVM and Clang packages directly from the LLVM repo. For the reviewer checking this... the original source for the LLVM part of the script is below.

Source: https://apt.llvm.org/llvm.sh

I made some minor modifications to the above script and Howard's Ubuntu Script to create a working Install Script for Debian.

I also added Debian Install instructions to the Docs and I added a Beta tag next to the Debian instructions in the Docs for clarity.

Test Plan

I have tested the script multiple times in Debian with no errors. I purged all installed packages and re-ran the script multiple times and got almost exactly the same output that you get when you run the Ubuntu Script in an Ubuntu OS.

Related PRs

(Link any related PRs here)

[joske]

Hi, thx for taking the time to make this. However, this is based on an older version of the ubuntu script. It's better form to only require root for the actions that need it (installing packages, firewall rules), and not for the build. This was updated a few days ago for the ubuntu script. Note that the ufw commands were removed, and it's left up to the user to make sure these ports are open.

As a general comment, I feel this script tries to do too much. I understand you need to fetch the LLVM packages as debian repos are always hopelessly outdated, but does this script really need to support all kinds of ubuntu and debian variants?

So please rebase your branch to bring it in line with the current script. I'll also add some comments on specific lines.

[fabrinasr]

I found a better solution for the best way to integrate Debian.

I think it is a mistake to create one script for Debian like we have for Ubuntu.

We should instead have a two step install process

Step 1) run the official script provided by the LLVM organisation to install updated version of Clang and LLVM for Debian

Step 2) run the SnarkOS Install script for Debian

The SnarkOS install script for Debian will be almost identical to the updated install script for Ubuntu,
The only difference will be that "apt-get clang" and "apt-get llvm" will be removed to avoid the installation of the outdated
versions of these packages in Debian.

This is in my opinion the best solution for three reasons:

1. we use the official install script provided by the LLVM organisation for Debian, this has already been
   tested by them, I believe there is no need to make changes to this. It is already working and stable.

2. we can avoid running the SnarkOS install script as root which is ideal.

3. In future, if we want to edit the Debian SnarkOS install script we will have a simple and clean file to edit,
   it makes life easier for devs. The Ubuntu and Debian install scripts will look almost identical.

I have made the following changes

1. Grabbed the official install script from LLVM for Debian and added to SnarkOS repo (Source: https://apt.llvm.org/llvm.sh)
2. Modified Ubuntu Install script for use in Debian
3. Edited readme to include install instructions for Debian

[joske]

Yes this seems like a better approach. I'm not sure we should bundle llvm.sh with snarkOS though.

[fabrinasr]

Yes, including a link to the llvm script in the readme is a better approach than bundling it. I removed the llvm script file.

[ljedrz]

LGTM, with the caveat that I don't currently have a Debian environment to test it in.

[joske]

The file build_debian.sh should be committed with 755 permissions.

[joske]

LGTM now

[joske]

The decision to merge is not mine. @howardwu will merge when appropriate. This is nice to have but not necessary for mainnet launch, we are focussing our efforts on mandatory changes ATM.

…

On Fri, 23 Feb 2024 at 15:34, fabrinasr ***@***.***> wrote: I can confirm I just tested on Debian and it is running fine but I do not have write access to this repo so it will not allow me to merge PR. Can you merge PR ? @joske <https://github.com/joske> — Reply to this email directly, view it on GitHub <https://github.com/AleoHQ/snarkOS/pull/3041#issuecomment-1961443567>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEB7RZPAR4IOEDPD34UOJDYVCSIXAVCNFSM6AAAAABCOQOKISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGQ2DGNJWG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fabrinasr]

I understand. I was thinking about it from the point of view of the people running Aleo Provers. I think Debian would be a better option for them. In my experience it is more stable than Ubuntu. This PR also made some minor improvements to the Ubuntu script. But I understand there might be bigger priorities right now for @howardwu

[fabrinasr]

@ljedrz

I re-added the instructions "cargo install --locked --path...." to the readme. It was originally removed here.

It is still needed, see here from @howardwu