Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATION] Remove triton v1 #658

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[DEPRECATION] Remove triton v1 #658

wants to merge 4 commits into from

Conversation

Qubitium
Copy link
Contributor

@Qubitium Qubitium commented Apr 28, 2024 •
edited

Reason for PR:

  • v2 is faster
  • v2 does everything v1 does

Ref: #655 (comment)

Changes:

  • remove v1 kernel
  • remove use_tritonv2
  • map use_triton to v2 kernel

Note:

  • trittonv2 file was not renamed to avoid any issues with git history
  • purposedly not added use_tritonv2 param mapping in code for backward compat.

TESTS

  • PASS: test_triton
  • PASS: test_quant
  • PASS: test_q4
  • PASS: test_serialization

@Qubitium Qubitium changed the title [WIP] Remove triton v1 Full deprecation of triton v1 Apr 28, 2024
@Qubitium Qubitium changed the title Full deprecation of triton v1 [DEPRECATION] Remove triton v1 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Qubitium