Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use GitHub token #904

Merged
merged 19 commits into from
May 17, 2024
Merged

Conversation

frtibble
Copy link
Contributor

@frtibble frtibble commented May 14, 2024

Purpose

This updates the Action which creates a release to:

  • Use the GitHub token rather that a PAT token, this means that releases will be created as the github-actions bot rather than as the user who generated the PAT
  • This requirement made it difficult to use release-please so I have opted to instead use the conventional-changelog-action. This has the same features (generates changelog, version number), however it allows us to publish the release directly, rather than creating a PR. This is important because the GitHub token does not have permissions to raise a PR on our behalf.
  • Note that, this does not mean releases will be published on every merge to main. They will only be published when a change results in a version increase.
  • It also means that release PRs do not need to be approved (this may be viewed as a good or a bad thing - we can discuss).

Does this introduce a breaking change?

  • Yes
  • No

Copy link

github-actions bot commented May 14, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
code
   app.py14140%5–8, 10–11, 14, 17–19, 22, 24, 26–27
   create_app.py130397%202, 207, 330
code/backend
   Admin.py21210%5–9, 11, 13–14, 17, 20–21, 23–24, 27, 34, 41, 44–46, 48, 50
code/backend/batch
   add_url_embeddings.py470100% 
   batch_push_results.py360100% 
   batch_start_processing.py260100% 
   function_app.py17170%1–8, 10, 12–14, 16, 19–22
   get_conversation_response.py320100% 
code/backend/batch/utilities/common
   answer.py28292%23, 51
   source_document.py60591%44, 47, 51, 55, 128
code/backend/batch/utilities/document_chunking
   __init__.py70100% 
   chunking_strategy.py15193%25
   document_chunking_base.py10280%10, 16
   fixed_size_overlap.py190100% 
   layout.py190100% 
   page.py170100% 
   paragraph.py9277%9, 15
   strategies.py15380%15–16, 18
code/backend/batch/utilities/document_loading
   __init__.py15193%16
   document_loading_base.py9188%13
   layout.py12558%9, 12–13, 16, 25
   read.py12558%9, 12–13, 16, 25
   strategies.py20575%17, 19, 22–23, 25
   web.py19194%23
   word_document.py251348%11–12, 22–24, 27, 30, 33–37, 45
code/backend/batch/utilities/helpers
   azure_blob_storage_client.py792963%19, 23–25, 33, 57–58, 61, 78–79, 81, 85, 141, 144, 163, 166, 168, 176–180, 203, 207–211, 213
   azure_computer_vision_client.py470100% 
   azure_form_recognizer_helper.py817013%11, 13, 16–17, 25, 27, 44–45, 52–55, 60–68, 73–75, 77–78, 81, 84–86, 88–90, 93, 97–98, 105–109, 111–114, 117–131, 133, 135–137, 139–140, 143, 145–147
   azure_search_helper.py490100% 
   document_chunking_helper.py13192%19
   document_loading_helper.py12191%14
   env_helper.py1341092%222, 227–228, 231–233, 245, 249–251
   llm_helper.py421173%40–41, 50, 61–62, 73, 86–87, 94, 113, 121
   orchestrator_helper.py13469%22–24, 27
code/backend/batch/utilities/helpers/config
   config_helper.py1340100% 
   embedding_config.py12191%27
code/backend/batch/utilities/helpers/embedders
   embedder_base.py5180%7
   embedder_factory.py10370%12–13, 15
   integrated_vectorization_embedder.py36488%20, 39–41
   push_embedder.py740100% 
code/backend/batch/utilities/integrated_vectorization
   azure_search_datasource.py190100% 
   azure_search_index.py350100% 
   azure_search_indexer.py230100% 
   azure_search_skillset.py220100% 
code/backend/batch/utilities/loggers
   conversation_logger.py362822%8, 11–12, 15–24, 27–30, 33–42, 46
code/backend/batch/utilities/orchestrator
   __init__.py110100% 
   lang_chain_agent.py601968%21–24, 26, 61–62, 82–85, 102–103, 106–109, 116–117
   open_ai_functions.py543633%62, 64, 70–73, 75, 78, 85–89, 93–94, 96, 102–106, 110–112, 115, 118–119, 122, 127–129, 132–134, 137, 142
   orchestration_strategy.py50100% 
   orchestrator_base.py50884%33, 72–74, 81–83, 93
   semantic_kernel.py540100% 
   strategies.py12741%8–13, 15
code/backend/batch/utilities/parser
   __init__.py7271%7, 11
   output_parser_tool.py390100% 
   parser_base.py9277%9, 19
code/backend/batch/utilities/plugins
   chat_plugin.py150100% 
   post_answering_plugin.py80100% 
code/backend/batch/utilities/search
   azure_search_handler.py58296%24, 30
   integrated_vectorization_search_handler.py61395%35, 111, 120
   search.py13192%15
   search_handler_base.py482352%13–15, 18–20, 24, 28, 32, 36, 40, 44, 48, 51–52, 54–56, 58–59, 62–63, 65
code/backend/batch/utilities/tools
   answer_processing_base.py8275%8, 12
   answering_tool_base.py9277%9, 15
   content_safety_checker.py412539%16, 18–19, 24, 30–32, 35–36, 42–43, 49–54, 57–59, 61, 65–67, 69
   post_prompt_tool.py170100% 
   question_answer_tool.py610100% 
   text_processing_tool.py16943%9, 12–15, 21, 23, 30, 37
code/backend/pages
   01_Ingest_Data.py70700%1–10, 12–14, 16, 22, 29, 32–33, 36–39, 41–44, 48–50, 53–55, 58–65, 68–70, 72, 75–78, 81, 86–88, 90–91, 93–94, 97–98, 102–104, 109–112, 119–120, 125, 131–132
   02_Explore_Data.py26260%1–7, 9–10, 12, 18, 25, 28, 36, 38–39, 41–44, 46–49, 52–53
   03_Delete_Data.py36360%1–7, 9–11, 13, 19, 26, 29, 37, 39–40, 42–45, 47, 49–50, 54, 58–62, 64, 67–68, 70–72
   04_Configuration.py1351350%1–9, 11–12, 14, 21, 28, 30, 35–44, 47–48, 51–62, 64–65, 67–69, 73–74, 86–90, 93–94, 98–100, 103–104, 107–108, 111–112, 135, 137–138, 140–144, 146–149, 152–156, 163–164, 174–176, 178, 198–199, 201, 203, 209, 217, 225, 232–233, 240, 242–243, 247, 255, 261, 268, 286–290, 296–297, 316–317, 321, 323–324, 347, 381–382, 384–385, 388–389, 392–395, 397–398, 400–402, 404–407, 409–410
TOTAL243367272% 

Tests Skipped Failures Errors Time
205 0 💤 0 ❌ 0 🔥 12.154s ⏱️

@frtibble frtibble requested a review from adamdougal May 14, 2024 12:46
gaurarpit
gaurarpit previously approved these changes May 14, 2024
ross-p-smith
ross-p-smith previously approved these changes May 14, 2024
@frtibble frtibble marked this pull request as draft May 14, 2024 13:11
@frtibble frtibble dismissed stale reviews from ross-p-smith and gaurarpit via 5c915b5 May 15, 2024 16:15
@frtibble frtibble marked this pull request as ready for review May 15, 2024 16:16
@frtibble
Copy link
Contributor Author

@gaurarpit , @ross-p-smith, @adamdougal - have pushed a few changes, this takes a slightly different approach so please see the description of the PR for an update. Happy to discuss in more detail tomorrow - this feels to me a cleaner solution than before.

.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cecheta cecheta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this in action 😀

@frtibble frtibble added this pull request to the merge queue May 17, 2024
Merged via the queue into Azure-Samples:main with commit 0dedf7f May 17, 2024
6 checks passed
@frtibble frtibble deleted the release-please-token branch May 17, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants