-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use GitHub token #904
ci: use GitHub token #904
Conversation
@gaurarpit , @ross-p-smith, @adamdougal - have pushed a few changes, this takes a slightly different approach so please see the description of the PR for an update. Happy to discuss in more detail tomorrow - this feels to me a cleaner solution than before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to seeing this in action 😀
Purpose
This updates the Action which creates a release to:
release-please
so I have opted to instead use the conventional-changelog-action. This has the same features (generates changelog, version number), however it allows us to publish the release directly, rather than creating a PR. This is important because the GitHub token does not have permissions to raise a PR on our behalf.Does this introduce a breaking change?