feat!: implement chat endpoint switch #905

gaurarpit · 2024-05-14T14:17:10Z

Purpose

Implement capability to switch endpoint to custom or byod based on env config to give flexibility to users for their needs.
Resolves Implement endpoint switch to custom #650

Does this introduce a breaking change?

Yes
No

How to Test

Test the code

poetry run pytest -m "not azure"

Run the application, with CONVERSATION_FLOW set to custom and byod

What to Check

Verify that the following are valid

Tests successfully pass
Validate the chat interface works, with both custom and byod

Other Information

Conversation API works as before:

github-actions · 2024-05-14T14:19:16Z

Coverage Report •

File	Stmts	Miss	Cover	Missing
code
create_app.py	137	3	97%	203, 208, 331
code/backend/batch/utilities/helpers
env_helper.py	137	10	92%	228, 233–234, 237–239, 251, 255–257
code/backend/batch/utilities/helpers/config
conversation_flow.py	4	0	100%
TOTAL	2473	672	72%

Tests	Skipped	Failures	Errors	Time
212	0 💤	0 ❌	0 🔥	11.966s ⏱️

…nput.

…point-switch' into arpit/feature/implement-chat-endpoint-switch

infra/main.bicep

…frontend app. Co-authored-by: Liam Moat <liam.moat@microsoft.com>

… CONVERSATION_FLOW

…nput.

…frontend app. Co-authored-by: Liam Moat <liam.moat@microsoft.com>

… CONVERSATION_FLOW

…point-switch' into arpit/feature/implement-chat-endpoint-switch # Conflicts: # infra/main.json

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

…nt-chat-endpoint-switch

adamdougal

LGTM! Can you remove [WIP] from the PR title?

…nt-chat-endpoint-switch

cecheta · 2024-05-21T15:32:19Z

I think this should be marked as a breaking change

ross-p-smith · 2024-05-21T22:03:04Z

I think this should be marked as a breaking change

Because this is a breaking change - I think we link to a new page from this link A backend that mimics the [On Your Data] flow, with the ability to switch to a custom backend. This could then document what these two endpoints do

gaurarpit · 2024-05-22T08:11:44Z

I think this should be marked as a breaking change

Because this is a breaking change - I think we link to a new page from this link A backend that mimics the [On Your Data] flow, with the ability to switch to a custom backend. This could then document what these two endpoints do

That's a very good suggestion. Will get something updated on the documentation today.

code/tests/test_app.py

code/create_app.py

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

adamdougal

cecheta · 2024-05-22T14:13:25Z

code/backend/batch/utilities/helpers/env_helper.py

@@ -4,6 +4,7 @@
 from dotenv import load_dotenv
 from azure.identity import DefaultAzureCredential, get_bearer_token_provider
 from azure.keyvault.secrets import SecretClient
+from backend.batch.utilities.helpers.config.conversation_flow import ConversationFlow


Because of the weird project structure, using an absolute import here breaks the Admin app and Azure Function when running in Azure

I think that using a relative import should fix it

gaurarpit added 2 commits May 14, 2024 15:13

Attribute to choose between custom and byod conversation types

6174b34

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

1ebdea0

gaurarpit self-assigned this May 14, 2024

gaurarpit and others added 8 commits May 15, 2024 15:40

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

34ecb33

add the /conversation binding to use the ChatConversationType as an i…

f12ef32

…nput.

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

4774eeb

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

65a7688

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

7c20822

Merge remote-tracking branch 'origin/arpit/feature/implement-chat-end…

695f3ed

…point-switch' into arpit/feature/implement-chat-endpoint-switch

Merge remote-tracking branch 'origin/arpit/feature/implement-chat-end…

d95fd89

…point-switch' into arpit/feature/implement-chat-endpoint-switch

Merge remote-tracking branch 'origin/arpit/feature/implement-chat-end…

73e7fbd

…point-switch' into arpit/feature/implement-chat-endpoint-switch

ross-p-smith reviewed May 15, 2024

View reviewed changes

infra/main.bicep Outdated Show resolved Hide resolved

infra/main.bicep Outdated Show resolved Hide resolved

infra/main.bicep Outdated Show resolved Hide resolved

gaurarpit and others added 17 commits May 16, 2024 10:33

fix typo

e4ac540

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

3f9fbd8

add the chat conversation type to main.json

2a983dc

add bicep params and make changes to call the /conversation from the …

7630b59

…frontend app. Co-authored-by: Liam Moat <liam.moat@microsoft.com>

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

5f3209c

undo premature bindings removal

629339c

update var name to a better suggestion from CHAT_CONVERSATION_TYPE to…

5b4221e

… CONVERSATION_FLOW

Merge branch 'main' into arpit/feature/implement-chat-endpoint-switch

2eecd7b

Attribute to choose between custom and byod conversation types

315a63d

add the /conversation binding to use the ChatConversationType as an i…

03a8070

…nput.

fix typo

e838b66

add the chat conversation type to main.json

130bfc4

add bicep params and make changes to call the /conversation from the …

813c312

…frontend app. Co-authored-by: Liam Moat <liam.moat@microsoft.com>

undo premature bindings removal

f0bd85e

update var name to a better suggestion from CHAT_CONVERSATION_TYPE to…

2573a04

… CONVERSATION_FLOW

Merge remote-tracking branch 'origin/arpit/feature/implement-chat-end…

ce99d31

…point-switch' into arpit/feature/implement-chat-endpoint-switch # Conflicts: # infra/main.json

merged and ran pre-commit again.

d37946b

liammoat and others added 7 commits May 21, 2024 10:58

chore: force poetry to use python 3.11

2a25b69

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

fix: use await when invoking conversation_custom

072a2f8

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

test: added test for conversation flow

37b4f2d

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

refactor: removing conversation flow specific endpoints

6e1a080

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

test: update test_app to use env_helper_mock, supporting new endpoint

dea40fb

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

test: test for failure condition on conversation flow

d12b2dc

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

Merge remote-tracking branch 'origin/main' into arpit/feature/impleme…

7f0fd5f

…nt-chat-endpoint-switch

gaurarpit marked this pull request as ready for review May 21, 2024 12:19

adamdougal previously approved these changes May 21, 2024

View reviewed changes

liammoat changed the title ~~feat: [WIP] implement chat endpoint switch~~ feat: implement chat endpoint switch May 21, 2024

Merge remote-tracking branch 'origin/main' into arpit/feature/impleme…

ea33999

…nt-chat-endpoint-switch

liammoat dismissed adamdougal’s stale review via ea33999 May 21, 2024 13:03

Update merged test with new endpoints.

42257f0

gaurarpit changed the title ~~feat: implement chat endpoint switch~~ !feat: implement chat endpoint switch May 21, 2024

gaurarpit changed the title ~~!feat: implement chat endpoint switch~~ feat!: implement chat endpoint switch May 21, 2024

cecheta reviewed May 22, 2024

View reviewed changes

code/tests/test_app.py Outdated Show resolved Hide resolved

ross-p-smith reviewed May 22, 2024

View reviewed changes

code/create_app.py Outdated Show resolved Hide resolved

liammoat and others added 3 commits May 22, 2024 13:16

refactor: switch to Enum of conversation flow

e9c860b

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

refactor: pylint for couple of lines

496c553

docs: documentation for conversation flow options

7ffe361

Co-authored-by: ArpitGaur <gaurarpit@gmail.com>

adamdougal approved these changes May 22, 2024

View reviewed changes

gaurarpit added this pull request to the merge queue May 22, 2024

Merged via the queue into main with commit 7621f8c May 22, 2024
11 checks passed

gaurarpit deleted the arpit/feature/implement-chat-endpoint-switch branch May 22, 2024 13:32

cecheta reviewed May 22, 2024

View reviewed changes

gaurarpit mentioned this pull request May 22, 2024

fix: Use relative path for ConversationFlow import so that shared code works in all applications #963

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: implement chat endpoint switch #905

feat!: implement chat endpoint switch #905

gaurarpit commented May 14, 2024 •

edited

github-actions bot commented May 14, 2024 •

edited

adamdougal left a comment

cecheta commented May 21, 2024 •

edited

ross-p-smith commented May 21, 2024

gaurarpit commented May 22, 2024 •

edited

adamdougal left a comment

cecheta May 22, 2024

feat!: implement chat endpoint switch #905

feat!: implement chat endpoint switch #905

Conversation

gaurarpit commented May 14, 2024 • edited

Purpose

Does this introduce a breaking change?

How to Test

What to Check

Other Information

github-actions bot commented May 14, 2024 • edited

adamdougal left a comment

Choose a reason for hiding this comment

cecheta commented May 21, 2024 • edited

ross-p-smith commented May 21, 2024

gaurarpit commented May 22, 2024 • edited

adamdougal left a comment

Choose a reason for hiding this comment

cecheta May 22, 2024

Choose a reason for hiding this comment

gaurarpit commented May 14, 2024 •

edited

github-actions bot commented May 14, 2024 •

edited

cecheta commented May 21, 2024 •

edited

gaurarpit commented May 22, 2024 •

edited