_pointerDownEvent now reuses the _activeTouchIds slot if _pointerMove… #15115
Conversation
…Event had already reserved it for this pointerId
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15115/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15115/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15115/merge#BCU1XR#0 |
|
Is there a way to simulate it in the input unit tests ? |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
On some devices, pen inputs can start with pointerMove instead of pointerDown. In that case, we were adding the pointerId to the _activeTouchIds in pointerMove, and instead of reusing that slot when pointerDown came along later, we were grabbing a second slot for the pointerId. Then later, when pointerUp came along, we only cleaned up one of them.
With this change, pointerDown will reuse the existing slot if found - grabbing a new slot only if this pointerId doesn't already have one, so we should no longer get one pointerId in two slots.
Reported in the forum here: https://forum.babylonjs.com/t/hitting-max-number-of-touches-exceeded-ignoring-touches-in-excess-of-5-when-using-a-pen-on-a-tablet-samsung-s-pen/50593