support qwen in openai compatible mode #3604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as https://help.aliyun.com/zh/dashscope/developer-reference/compatibility-of-openai-with-dashscope/?spm=a2c4g.11186623.0.0.5ab04bb0SFbKjC says, DashScope provides an OpenAI-compatible interface for many qwen models but it can't support the optional user paramater after test out
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krrishdholakia
requested changes
May 13, 2024
| @@ -5849,6 +5849,7 @@ def _map_and_modify_arg(supported_params: dict, provider: str, model: str): | |||
| for k in passed_params.keys(): | |||
| if k not in default_params.keys(): | |||
| optional_params[k] = passed_params[k] | |||
| if custom_llm_provider == "openai" and "qwen" in model: optional_params.pop("user", None) | |||
There was a problem hiding this comment.
@allen12921 we have a list of 'openai_compatible_providers', can you add it there instead -
Line 379 in 514c573
And add a working example to docs - e.g. -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as dashscope developer-reference says, DashScope provides an OpenAI-compatible interface
https://dashscope.aliyuncs.com/compatible-mode/v1for many qwen models but it can't support the optional 'user' paramater and litellm always add this paramaterType
🐛 Bug Fix
Changes
Remove the optional 'user' paramater for model whose name is started with 'qwen'
Pre-Submission Checklist (optional but appreciated):
OS Tests (optional but appreciated):