-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST7781_driver #1181
base: master
Are you sure you want to change the base?
ST7781_driver #1181
Conversation
Thanks for your input, nicely done. I do not have one of those displays so I am unable to test, this is a problem for me if a user has an issue later and typically in these situations I have been forced to buy a display to fix problems! Can you provide a link to a display vendor. I am not sure why the following sequence:
is required, and why it is only needed for pushBlock(). If it is important there, then I would expect it to be needed in many other functions. Can you expalin this? There is no single example that tests all library functions, so as a confidence test can you list all the library examples you have run and whether they worked without error? As a minimum all these, these and these should run fine on an ESP32. Sprite tests are also good to run as that provides confidence the displau support has not missed anything. |
Hi! Well, searched for vendor and invoice and didn't found any register :(, I buy this maybe 10 years ago, recently I re-using old projects parts and wanted use theses displays. I have 2, and if you want I can send one for free. https://www.engineersgarage.com/arduino/displaying-text-on-tft-lcd/ On back has 2 x 74HC245 and 1 x AMS1117, is too much like common TFT 2.4" ILI9341, maybe is cheap clone. About:
Maybe become a little lazy, on test and tiring fix rotation, I found it on references sources, and it make work some calls like fillRect() with normally is after flood()/rotation().
I truly don't known why is need, but worked, with little time today, I re-checked and removed it.. and worked without it, I think is directly related with correct flags on rotation. On old test, rotate didn't rotate current contents on display, only remap references, or I still don't known, so, we can remove it.. About tests, I tested some Sprites, one show some trouble 'Animated_dial' on needle background, I need more time to tests all and check issues, maybe on weekend. And need figure out how GIT works and rollback/fix the pull, because I from CVS and SVN.... Thanks. |
The 'Animated_dial' example reads from the display so changes to the readAddrWindow() function may be required. Some displays however do not allow reading from the display so this capability is not critical. |
…into ST7781_driver
Hi! Tests done, report in file attached. I'm stating using Git, still confusing.. |
Hello! |
If is same, you can try out my fork, branch ST7781_driver, is full working with ST7781: https://github.com/kakaroto33/TFT_eSPI/tree/ST7781_driver See files for referency: |
Hi!
This is my first time making pull request, and my English is not so good.
The driver is for ST7781 / SPFD5408 (MCUFIREND shield), I tested with ESP 32 Dev Kit.
I used by reference this sources:
https://github.com/compihu/SWIFT-Shield
https://github.com/prenticedavid/MCUFRIEND_kbv (Defines is from there)
Docs:
https://www.crystalfontz.com/controllers/Sitronix/ST7781/
https://www.rhydolabz.com/documents/SPFD5408A.pdf
Major changes is on core:
My shield is parallel one, and tested on with ESP 32 only, on examples I put one adaption of tftpaint with resistive touch library (Adafruit).
I tested some exemples, like graphictest, animated_eyes, clock and worked without problems.
Anyways, thanks for great project.