Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] examples for gen2 sdks (for quickstart docs and using real content) #3291

Closed

Conversation

sidmohanty11
Copy link
Contributor

Description

Add a short description of what changes you made, why you made them, and any other context that you think might be helpful for someone to better understand what is contained in this pull request. This sort of information is useful for people reviewing the code, as well as anyone from the future trying to understand why changes were made or why a bug started happening.

Screenshot
If relevant, add a screenshot or two of the changes you made.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-app-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:19pm
nextjs-pages-router-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:19pm
remix-gen2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:19pm
svelte-vite-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:19pm

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: c179845

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented May 14, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/nuxt/pages/[...slug].vue View secret
- Generic High Entropy Secret 4e32e03 packages/sdks/examples/react/src/App.tsx View secret
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/nextjs-pages-router/src/pages/[...page].tsx View secret
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/svelte-kit/src/routes/[...catchall]/+page.server.js View secret
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/vue/src/App.vue View secret
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/nextjs-app-router/app/[...slug]/page.tsx View secret
- Generic High Entropy Secret 14b2e47 packages/sdks/examples/nextjs-pages-router/src/pages/[...page].tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sidmohanty11
Copy link
Contributor Author

Will follow this #3295 architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant