Adding SSL certificate + key file parameters to run command (passthrough to uvicorn webserver) #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share more about your use case where the reverse proxy isn't an option? |
|
closing in favor of #933 |
|
Sorry @tpatel , life got busy and I missed this thread. Glad to see another PR with similar functionality is being merged, pending those changes requested. For the record we have requirements where the content needs to be encrypted at the source, even as it's traversing over our local network to the distinct proxy server (not a local node container), per our network security policy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added optional parameters to pass an SSL certificate file and key file through to the webserver in the run command, as either a CLI or env var using the existing pattern, so that traffic can be secured from the app source (installing behind a reverse-proxy might not be desirable in all cases, and if the proxy is outside the host or container of this app there might be security constraints requiring that traffic to be encrypted as well, which was the reason I implemented this for my use case). This passes through to the webserver (uvicorn) config object, and I have confirmed it provides an SSL connection from the source when proper cert+key files are used.