Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-lambda] Add requestHeaders to AppSyncAuthorizerEvent #69566

Conversation

auvred
Copy link
Contributor

@auvred auvred commented May 10, 2024

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 10, 2024

@auvred Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69566,
  "author": "auvred",
  "headCommitOid": "d81983d0cd3921138aaba315db95e0e6eafc84f1",
  "mergeBaseOid": "18753976aad3956a963c3cafeeab6755b7c879a3",
  "lastPushDate": "2024-05-10T09:47:15.000Z",
  "lastActivityDate": "2024-05-16T16:08:10.000Z",
  "mergeOfferDate": "2024-05-16T16:08:01.000Z",
  "mergeRequestDate": "2024-05-16T16:08:10.000Z",
  "mergeRequestUser": "auvred",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "aws-lambda",
      "kind": "edit",
      "files": [
        {
          "path": "types/aws-lambda/test/appsync-resolver-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/aws-lambda/trigger/appsync-resolver.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "darbio",
        "skarum",
        "StefH",
        "buggy",
        "wwwy3y3",
        "OrthoDex",
        "MichaelMarner",
        "daniel-cottone",
        "kostya-misura",
        "coderbyheart",
        "palmithor",
        "daniloraisi",
        "simonbuchan",
        "Haydabase",
        "repl-chris",
        "aneilbaboo",
        "jeznag",
        "louislarry",
        "dpapukchiev",
        "ohookins",
        "trevor-leach",
        "jagregory",
        "dalen",
        "loikg",
        "skyzenr",
        "redlickigrzegorz",
        "juancarbonel",
        "pwmcintyre",
        "alex-bolenok-centralreach",
        "marianzange",
        "apalumbo",
        "SachinShekhar",
        "ivanmartos",
        "zach-anthony",
        "savnik",
        "bboure",
        "jamesorlakin",
        "aphex",
        "joeykilpatrick",
        "lmanerich"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-16T16:07:24.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "darbio",
      "date": "2024-05-13T01:53:11.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "simonbuchan",
      "date": "2024-05-11T04:21:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2104302465,
  "ciResult": "pass"
}

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 10, 2024
@simonbuchan
Copy link
Contributor

Thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 11, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 16, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in New Pull Request Status Board May 16, 2024
@auvred
Copy link
Contributor Author

auvred commented May 16, 2024

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot merged commit 09d8f7e into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants