Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #69568

Closed
wants to merge 3 commits into from
Closed

Conversation

jafarsaad
Copy link

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 10, 2024

@jafarsaad Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 15 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69568,
  "author": "jafarsaad",
  "headCommitOid": "4974664fc1022ae04cc03169d985372bca795e5c",
  "mergeBaseOid": "e88141635a19a9bb5890958f8093c5ded76973aa",
  "lastPushDate": "2024-05-10T16:45:55.000Z",
  "lastActivityDate": "2024-05-14T16:39:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": ".devcontainer/devcontainer.json",
          "kind": "infrastructure"
        },
        {
          "path": ".github/workflows/webpack.yml",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2024-05-10T21:20:47.000Z",
      "abbrOid": "5aaebd4"
    }
  ],
  "mainBotCommentID": 2104921674,
  "ciResult": "unknown"
}

@typescript-bot
Copy link
Contributor

🔔 @jafarsaad — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@DangerBotOSS
Copy link

DangerBotOSS commented May 10, 2024

Formatting

The following files are not formatted:

  1. .devcontainer/devcontainer.json
  2. .github/workflows/webpack.yml

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 4974664

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board May 10, 2024
Copy link
Author

@jafarsaad jafarsaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but I don't think this is right; if we wanted a devcontainer, it'd be a Node image, but even still, opening the entire repo up is not the best way to work in DT so I wouldn't feel comfortable recommending this.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 10, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Needs Author Action in New Pull Request Status Board May 10, 2024
@typescript-bot
Copy link
Contributor

@jafarsaad One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@jafarsaad jafarsaad requested a review from jakebailey May 11, 2024 17:03
@jafarsaad jafarsaad marked this pull request as draft May 11, 2024 17:03
@jafarsaad jafarsaad closed this May 11, 2024
@jafarsaad jafarsaad reopened this May 11, 2024
@jafarsaad jafarsaad marked this pull request as ready for review May 11, 2024 18:39
@jafarsaad jafarsaad closed this May 14, 2024
@jafarsaad jafarsaad reopened this May 14, 2024
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Revision needed This PR needs code changes before it can be merged. labels May 25, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 25, 2024
@typescript-bot
Copy link
Contributor

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@jafarsaad jafarsaad marked this pull request as draft May 25, 2024 20:28
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 25, 2024
@jafarsaad jafarsaad closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants