Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-js][office-js-preview] (common) Document device permission API #69592

Conversation

samantharamon
Copy link
Contributor

Please fill in this template.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: None.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 13, 2024

@samantharamon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69592,
  "author": "samantharamon",
  "headCommitOid": "279223e2a39d84a9e60c7011f945f5edd3e2f4ea",
  "mergeBaseOid": "4bb4074c7626d9ed78c2c5243476539d6dc161b0",
  "lastPushDate": "2024-05-13T16:55:05.000Z",
  "lastActivityDate": "2024-05-16T18:35:11.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Rick-Kirkham",
      "date": "2024-05-16T17:30:24.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "AlexJerabek",
      "date": "2024-05-13T17:33:24.000Z",
      "abbrOid": "f9c8afb"
    }
  ],
  "mainBotCommentID": 2108222179,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels May 13, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@samantharamon
Copy link
Contributor Author

@AlexJerabek tagging for review.

Copy link
Contributor

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Please repeat them in the other d.ts file too.

types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
types/office-js-preview/index.d.ts Show resolved Hide resolved
types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 13, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

@samantharamon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label May 13, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board May 13, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 13, 2024
@typescript-bot
Copy link
Contributor

@AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 13, 2024
@samantharamon samantharamon marked this pull request as draft May 13, 2024 18:19
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 13, 2024
@samantharamon samantharamon marked this pull request as ready for review May 16, 2024 18:35
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

@AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT merged commit cb74c94 into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@samantharamon samantharamon deleted the office-js-device-permission-api branch May 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants