-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(@rdfjs/serializer-rdfjs): is actually ESM #69601
base: master
Are you sure you want to change the base?
Conversation
@tpluscode Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 14 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69601,
"author": "tpluscode",
"headCommitOid": "57e87d4a4e012abb25a0bb1a6e2b6a9c20427fa9",
"mergeBaseOid": "cb74c940100800002511f412841ecd6cdc4c4e65",
"lastPushDate": "2024-05-14T11:27:26.000Z",
"lastActivityDate": "2024-05-14T11:27:26.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "attw.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical",
"isSafeInfrastructureEdit": true
},
{
"name": "rdfjs__serializer-rdfjs",
"kind": "edit",
"files": [
{
"path": "types/rdfjs__serializer-rdfjs/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"tpluscode",
"BenjaminHofstetter"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2109959996,
"ciResult": "pass"
} |
🔔 @BenjaminHofstetter — please review this PR in the next few days. Be sure to explicitly select |
@tpluscode Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
Re-ping @BenjaminHofstetter: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
No description provided.