Convert iso-8859-1 encoded files to UTF8 encoding #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting non-English messages may break them in game. Need test it on runtime. |
| @@ -138,15 +138,15 @@ const char *French_strings[] = { | |||
| "Votre processeur et votre systFme doivent prendre en charge Katmai pour exTcuter ce jeu."}; | |||
|
|
|||
| const char *German_strings[] = { | |||
| "Descent3 unter Windows NT ben�tigt fnr die Ausfnhrung die NT-Version 4.0 oder h�her", | |||
| "Descent 3 ben�tigt fnr die Ausfnhrung Windows 9x, NT 4.0 oder h�her.", | |||
| "Descent3 unter Windows NT ben÷tigt fnr die Ausfnhrung die NT-Version 4.0 oder h÷her", | |||
There was a problem hiding this comment.
The German umlauts are still looking wonky.
Jayman2000
suggested changes
Apr 22, 2024
There was a problem hiding this comment.
- I recommend putting
fixes #145into the description of this pull request so that that issue automatically gets closed when this PR is merged. - I think that you should split this change into two different commits, one that converts things to UTF-8, and one that switches to LF line endings. We may find a bug in the future that is caused by switching to UTF-8, but not caused by switching to LFs. If we do end up finding such a bug, it will be easier to use
git-bisectto figure out what’s going on if these two big changes are in separate commits.
The following script was used convert the file encodings.
```
for filename in $(find)
do
encoding=$(file -b --mime-encoding $filename)
if [ "$encoding" = "iso-8859-1" ]; then
iconv -f iso-8859-1 -t utf8 ${filename} -o ${filename}.utf8
mv ${filename}.utf8 ${filename}
fi
done
```
Do you mean #129? |
@winterheart How can I start D3 in a specific language? |
I think it uses your system language. |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following script was used convert the file encodings.