Cleanup comments in save & load related files #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This definition was used to control the accessibility of some class members, changing protected qualifiers to public. This introduced unnecessary coupling between components and headers. All conditional access specifiers have been set to public, which should not be a problem given the low number of classes that actually used affected members. Another albeit more complex solution could have been to use friend classes.
D3 used to support Aureal 3-Dimensional sound cards, providing 3D spatial audio. The hardware and drivers is outdated, so all support in code has been removed, including UI mixer setting. Read more about A3D here: https://en.wikipedia.org/wiki/Aureal_Semiconductor#A3D
- Remove commented code - Move versioning comments to header - Add comments in gamesave.cpp for readability
Lgt2x
reviewed
May 15, 2024
Descent3/loadstate.cpp
Outdated
| //@@ // movement info. | ||
| //@@ switch (op->movement_type) | ||
| //@@ { | ||
| //@@ case MT_SHOCKWAVE: |
There was a problem hiding this comment.
do you have any idea what this whole code block could have been for?
There was a problem hiding this comment.
If you search @ you'll find a lot of files with commented blocks like this one. In this block, it looks like old loading code that was replaced.
Remove DDAccess.h header, and associated DD_ACCESS_RING definition
Remove Aureal support
Remove unused cf_ReadHogFileEntry() function.
All functions, that uses cf_ReadBytes(), checks return size, but don't handle potential exceptions. That leads to segfaults on reading of damaged files (i.e. broken savegames).
replace md5 with custom implementation, with tests
Converted line endings to Unix format to match .gitattributes file
Deleted left over VS project file.
…into gamesave-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description