Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display user score in discover view and filter it more flexable. #626

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

wjh000123
Copy link

Description

The score cannot be seen in discover view, but the api has voteAverage data, just show it on the page. And the filter slide has default step=1, which is not very flexable, for I might be interested in movies that is larger than 7.5, or so. Just make the score filter more flexable by set the step to 0.1.

Screenshot (if UI-related)

[discover] before:

image

[discover] after:

image

[filter slide] after:

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@Gauvino
Copy link
Contributor

Gauvino commented Jan 19, 2024

Does adding a settings by user if they want to see the score or not so it's not in default built-in

@wjh000123
Copy link
Author

Does adding a settings by user if they want to see the score or not so it's not in default built-in

That's OK, and where the setting section should this option be in?

@Gauvino
Copy link
Contributor

Gauvino commented Jan 19, 2024

Does adding a settings by user if they want to see the score or not so it's not in default built-in

That's OK, and where the setting section should this option be in?

The most coherent for me I think is in the profile settings on the bottom left when clicking settings

@Fallenbagel
Copy link
Owner

IMHO that makes discover posters very cluttered from an already cluttered view

@wjh000123
Copy link
Author

IMHO that makes discover posters very cluttered from an already cluttered view

How about show the score on hover?

@Fallenbagel
Copy link
Owner

IMHO that makes discover posters very cluttered from an already cluttered view

How about show the score on hover?

Dont we already have the watchlist button occupying that space on hover? Imagine already requested ones. It will have media type badge, watchlist button, score badge. It will also kind of make mobile/touch ux a bit harder

@wjh000123
Copy link
Author

Dont we already have the watchlist button occupying that space on hover? Imagine already requested ones. It will have media type badge, watchlist button, score badge. It will also kind of make mobile/touch ux a bit harder

Yep, maybe we can do a little change to the UI. Maybe make the watchlist button more compact, like only show the icon. Another proposal is, how about make the watchlist button the same style as request button, and below it. From my understanding, watchlist and request are some kind of similar action, which stands for the interest.

image

@Gauvino
Copy link
Contributor

Gauvino commented Jan 19, 2024

Dont we already have the watchlist button occupying that space on hover? Imagine already requested ones. It will have media type badge, watchlist button, score badge. It will also kind of make mobile/touch ux a bit harder

Yep, maybe we can do a little change to the UI. Maybe make the watchlist button more compact, like only show the icon. Another proposal is, how about make the watchlist button the same style as request button, and below it. From my understanding, watchlist and request are some kind of similar action, which stands for the interest.

image

By the picture you make I can say that it's impossible to make it like that cause don't forget that they're is other language than English and movie translation or series can be more longer so it will break everything I think

@Gylesie
Copy link
Contributor

Gylesie commented Jan 25, 2024

I think displaying rating is such a nice feature to have, would save a ton of clicks into details. However, I agree the current draft design looks awfully clustered, as @Fallenbagel noted. I even think that the favourites icon should be redesigned too to a solid design, because currently it does not fit aesthetically with the overseer's style. I can't really think of a nice way of doing this.

We could replace the "movie" "series" label with something more simple, but that would be a big change, and I kind of got used to the label and like it. Or maybe some kind of hover animation in place of the label, but not sure, that would not work on mobile UI that great.

Maybe lowering the font size a bit and max. length of the description?

Having it on the side close to the right border?

All of the options above dont feel right to me. Any other ideas?

Edit: Actually, I what about moving the favourites icon somewhere else, details page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants