Gui: Fix NaviCube drawing and interaction with Qt6 #14159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Core
|
Nice, works perfect with both Qt5 and Qt6. |
YakoYakoYokuYoku
force-pushed
the
fix-navi-cube-qt6
branch
from
2266fec
to
a8e4fc5
Compare
YakoYakoYokuYoku
force-pushed
the
fix-navi-cube-qt6
branch
from
a8e4fc5
to
7284552
Compare
|
@Rexbas, please try this version, as this will only make the context current at the proper time. |
|
Still works perfect! |
|
Awesome, thanks for this! |
adrianinsaval
added
the
Backport todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that while debugging the NaviCube with a FreeCAD Qt6 build OpenGL errors are produced when picking faces or buttons. It turns out that these errors are produced because the underlying framebuffer object has a different context than the one that was created with, more specifically, QtWebEngine changes it before the mouse event is processed. I've fixed this by setting making the proper context current explicitly at the 3D Inventor viewer when Navicube has to process the event. Please test this and give your comments before merging. Fixes #13494.