Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: update testnet URLs #2272

Merged
merged 16 commits into from
May 17, 2024
Merged

chore!: update testnet URLs #2272

merged 16 commits into from
May 17, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 8, 2024 •
edited

Breaking Changes:

  • Constant FUEL_BETA_5_NETWORK_URL was renamed to FUEL_TESTNET_NETWORK_URL

@Torres-ssf Torres-ssf self-assigned this May 8, 2024
@Torres-ssf
Copy link
Contributor Author

Blocked until the Block explorer is updated to fuel-core ~ 0.26

@Torres-ssf
Copy link
Contributor Author

Blocked until the Block explorer is updated to fuel-core ~ 0.26

After speaking with @LuizAsFight I could validate that the block explorer URL will not change after the upgrade, therefore, this PR is no longer blocked.

@nedsalk nedsalk changed the title chore: update testnet URLs chore!: update testnet URLs May 16, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review May 16, 2024 14:16
@fuel-service-user
Copy link
Contributor

fuel-service-user commented May 16, 2024 •
edited

✨ A PR has been created under the rc-2272 tag on fuels-wallet repo.
FuelLabs/fuels-wallet#1306

@Torres-ssf Torres-ssf enabled auto-merge (squash) May 17, 2024 11:18
petertonysmith94
petertonysmith94 approved these changes May 17, 2024
View reviewed changes
.textlintrc.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.84%(+0.02%) 70.71%(+0.15%) 76.87%(-0.03%) 79.92%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/utilities.ts 63.63%
(+43.63%)		 92.3%
(+92.3%)		 66.66%
(+16.66%)		 65.21%
(+37.94%)

@Torres-ssf Torres-ssf merged commit 3f86778 into master May 17, 2024
19 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/update-testnet-url branch May 17, 2024 11:48
@fuel-service-user fuel-service-user mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update old / beta5 URLs
7 participants
@Torres-ssf @fuel-service-user @arboleya @danielbate @maschad @petertonysmith94 @nedsalk