Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add integration test for the create fuels template #2278

Merged
merged 40 commits into from
May 28, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented May 9, 2024

Summary

This PR adds an e2e test for the create fuels template. This test simulates the user opening the page, topping up their burner wallet, clicking 'increment', and verifies that the counter is incremented as expected.

While this PR only adds a test for the counter contract, we should add tests for the predicate and script examples in the template as well - maybe in separate PRs.

Closes #2264

@Dhaiwat10 Dhaiwat10 added the feat label May 9, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this May 9, 2024
@Dhaiwat10 Dhaiwat10 changed the title test: add e2e tests for the create fuels template test: add e2e test for the create fuels template May 20, 2024
@Dhaiwat10 Dhaiwat10 changed the title test: add e2e test for the create fuels template feat: add e2e test for the create fuels template May 20, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review May 20, 2024 20:18
@Dhaiwat10 Dhaiwat10 dismissed stale reviews from petertonysmith94 and maschad via 0a2fbed May 24, 2024 19:05
@Dhaiwat10
Copy link
Member Author

@danielbate @arboleya renamed e2e -> integration

maschad
maschad previously approved these changes May 26, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) May 27, 2024 17:16
@Dhaiwat10 Dhaiwat10 dismissed danielbate’s stale review May 27, 2024 17:17

Change addressed

@Dhaiwat10 Dhaiwat10 requested a review from maschad May 27, 2024 17:19
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we can bundle the create-fuels-template-integration step into the environments step somehow 🤔

Approving - as I believe this provides value and we can look over this in #2170.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
46.34%(-0.01%) 39.55%(+0%) 43.51%(+0%) 46.16%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-response/transaction-response.ts 70.37%
(+0.56%)
50%
(+0%)
75%
(+0%)
70.37%
(+0.56%)
🔴 packages/account/src/providers/transaction-summary/operations.ts 37.27%
(+0.34%)
10.9%
(+0%)
45%
(+0%)
36.13%
(+0.3%)

@Dhaiwat10 Dhaiwat10 merged commit ffc62ba into master May 28, 2024
20 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-template-e2e-tests branch May 28, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e tests for the create fuels template app
7 participants