Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ethers from abi-coder #2297

Merged
merged 8 commits into from
May 14, 2024
Merged

chore: remove ethers from abi-coder #2297

merged 8 commits into from
May 14, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented May 14, 2024

Closes #2292

@maschad maschad changed the title chore: remove ethers from abi-coder chore: remove ethers from abi-coder May 14, 2024
@maschad maschad self-assigned this May 14, 2024
danielbate
danielbate previously approved these changes May 14, 2024
View reviewed changes
Torres-ssf
Torres-ssf previously approved these changes May 14, 2024
View reviewed changes
@maschad maschad enabled auto-merge (squash) May 14, 2024 12:14
@maschad maschad disabled auto-merge May 14, 2024 13:42
@maschad maschad enabled auto-merge (squash) May 14, 2024 13:43
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0.25%) 70.29%(+0.45%) 77.21%(+0.09%) 79.89%(+0.24%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/mnemonic/utils.ts 97.61%
(+19.15%)		 91.66%
(+28.03%)		 100%
(+0%)		 97.77%
(+18.06%)
🔴 ✨ packages/utils/src/utils/toUtf8Bytes.ts 88%
(+88%)		 84.61%
(+84.61%)		 100%
(+100%)		 88.46%
(+88.46%)
🔴 ✨ packages/utils/src/utils/toUtf8String.ts 94.64%
(+94.64%)		 92.3%
(+92.3%)		 100%
(+100%)		 94.73%
(+94.73%)

@maschad maschad merged commit 0651a5f into master May 14, 2024
19 checks passed
@maschad maschad deleted the mc/refactor/remove-ethers-abi-coder branch May 14, 2024 20:24
@fuel-service-user fuel-service-user mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

Assignees

@maschad maschad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: remove ethers from abi-coder
4 participants
@maschad @danielbate @petertonysmith94 @Torres-ssf