Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers providers Interfaces to fetch image/video URLs #5265

Merged
merged 6 commits into from
May 23, 2024

Conversation

JcMinarro
Copy link
Member

🎯 Goal

The SDK already provided the ImageHeadersProvider interface to inject custom headers whenever an image URL wanted to be loaded. This interface has been updated to receive as a parameter the URL that will be fetched to be able to inject different headers depending on the URL.

In the same way, the VideoHeadersProvider interface has been created to use custom headers when video URLs are fetched.

🎉 GIF

@JcMinarro JcMinarro requested a review from kanat May 17, 2024 13:49
@JcMinarro JcMinarro requested a review from a team as a code owner May 17, 2024 13:49
CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JcMinarro JcMinarro merged commit 568ebae into develop May 23, 2024
7 checks passed
@JcMinarro JcMinarro deleted the feature/headers-providers branch May 23, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants