Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI tests failures on older iOS versions #3205

Closed
wants to merge 162 commits into from
Closed

CI tests failures on older iOS versions #3205

wants to merge 162 commits into from

Conversation

laevandus
Copy link
Contributor

🎯 Goal

Some tests failed on older iOS versions

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@laevandus
Add a new chat state layer with sending messages, message loading, an…
cc6b89a 
…d typing indicator support
@laevandus
Add freeze, unfreeze, update, updatePartial to Chat
36bc97c
@laevandus
Add mute and unmute to Chat
d028372
@laevandus
Add hide and show to Chat
f412ecd
@laevandus
Add delete and truncate to Chat
4000ce7
@laevandus
Add slow mode to Chat
08b475e
@laevandus
Add add/remove members to Chat
4dc8c43
@laevandus
Add invite members, accept invite and reject invite to Chat
9960c4f
@laevandus
Force main actor when mutating ChatState messages
7752e2c
@laevandus
Add deleteFile, deleteImage and uploadAttachment to Chat
eda1a66
@laevandus
Align argument types in Chat
1eb79da
@laevandus
Add loadPinnedMessages to Chat
60c3fcc
@laevandus
Add enrichURL to Chat
91f397c
@laevandus
Start observing channel updates in ChatState and add markRead and mar…
14b55f3 
…kUnread to Chat
@laevandus
Add watch and stopWatching to Chat
9d455c8
@laevandus
Add remainingCooldownDuration to ChatState
1269630
@laevandus
Expose pagination state through ChatState
06aabc3
@laevandus
Add missing capabilities checks to Chat
dccd2d7
@laevandus
Observe messages list changes and update ChatState.messages
6bf9a80
@laevandus
Load messages from date to date when paginating with Chat
6a0573a
@laevandus
Rename chat factory methods
1efafd5
@laevandus
Pass event notification center to ChatState observer but do not obser…
e3d6f7a 
…ve it
@laevandus
Do not force reload the first page
ae3f3ce
@laevandus
Add pinMessage and unpinMessage to Chat which waits until API request…
933c56c 
… has finished
@laevandus
Rename message pagination methods
1da0f2b
@laevandus
Tidy main actor handling and capabilities
cf585fe
@laevandus
Add sendReaction, deleteReaction and loadReactions to Chat
9782e92
@laevandus
Add translateMessage, resendMessage, deleteMessage, flagMessage, unfl…
d08a8bc 
…agMessage sendMessageAction and resendAttachment to Chat
@laevandus
Add MessageState for observing reactions and replies, reactions and r…
a406588 
…eplies paginated loading, and tidy message loading
@laevandus
Rename interactors to have more specific names in chat
840cbbb
laevandus and others added 12 commits May 15, 2024 11:21
@laevandus
Reformat long functions in workers
a9532f0
@laevandus
Remove duplicate queries when syncing channel lists
68a9341
@laevandus
[ChatStateLayer] Use a single channel list linker for linking and unl…
a3f2801 
…inking channels f… (#3190)

* Use a single channel list linker for linking and unlinking channels from query

* Remove events controller from ChatChannelListController
@laevandus
[ChatStateLayer] Share mark and mark unread message (#3194)
18ea112
@laevandus
Update the version number in documentation
89da909
@laevandus
Add an entry to changelog
025a226
@laevandus
Remove shouldAddNewChannelToList and shouldListUpdatedChannel since t…
d97594e 
…hese are never called anymore (#3198)
@laevandus
Tracked channel list queries were reset after first sync
7945ee1
@laevandus
Remove implicitly unwrapped optionals from APIClient_Spy
deafde8
@laevandus
Remove the comment about isFlaggedByCurrentUser
aef62e0
@testableapple
Archive test logs (#3199)
28a1dcf
@Stream-iOS-Bot
[CI] Sync Mock Server (#3200)
f3fe656
@laevandus laevandus added the 🤖 CI/CD Any work related to CI/CD label May 17, 2024
@laevandus laevandus requested a review from a team as a code owner May 17, 2024 08:12
@laevandus laevandus changed the title ChannelList tests failed on older iOS versions due to timing issues CI tests failures on older iOS versions May 17, 2024
@laevandus laevandus marked this pull request as draft May 17, 2024 08:13
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 1.67 ms 83.3% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 0.66 ms per s 83.5% 🔼 🟢
Frame rate 79 fps 78.44 fps 0.71% 🔼 🟢
Number of hitches 1 0.2 80.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 0.0 ms 100.0% 🔼 🟢
Duration 2.6 s 0.97 s 62.69% 🔼 🟢
Hitch time ratio 5 ms per s 0.0 ms per s 100.0% 🔼 🟢
Frame rate 76 fps 72.06 fps 5.18% 🔼 🟢
Number of hitches 1.2 0.0 100.0% 🔼 🟢

@laevandus laevandus marked this pull request as ready for review May 17, 2024 13:18
@laevandus laevandus enabled auto-merge (squash) May 17, 2024 13:31
@Stream-iOS-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 6.68 ms 33.2% 🔼 🟢
Duration 2.6 s 2.53 s 2.69% 🔼 🟢
Hitch time ratio 4 ms per s 2.65 ms per s 33.75% 🔼 🟢
Frame rate 79 fps 77.86 fps 1.44% 🔼 🟢
Number of hitches 1 0.8 20.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 0.0 ms 100.0% 🔼 🟢
Duration 2.6 s 0.82 s 68.46% 🔼 🟢
Hitch time ratio 5 ms per s 0.0 ms per s 100.0% 🔼 🟢
Frame rate 76 fps 63.95 fps 15.86% 🔼 🟢
Number of hitches 1.2 0.0 100.0% 🔼 🟢

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
103 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@laevandus
Increase the function_body_length rule's warning from 120 to 150 (#3201)
d5155b0 
Measure SDKs on release (#3206)

Fetch tags for release workflow (#3209)

Bump Xcode version on cron checks (#3208)

[Threads v2] Add `ChatThreadListController` (#3207)

* Provide default arguments to the thread queries to make it less confusing

* Add `ChatThreadListController` to query threads

* Fix threads not appearing because of To-One relationship instead of To-Many

* Fix threads appearing duplicated on first fetch

* Make the `watch` a required argument of the Thread List Query

* Add function to load local thread

* Add test coverage to ThreadListUpdater

* Add ThreadListController test coverage

* Add SwiftUI and Combine Helpers

* Move cursor logic to controller

* ThreadListUpdater -> ThreadsRepository

* Fix comment typo

ChannelList tests failed on older iOS versions due to timing issues

Do not reset members and watchers when loading more messages

Increase unit-test timeout since test_hugeChannelListQuery_save_DB_empty can run slowly on CI

Try demangled name crash on older iOS versions

Build error on older Xcodes

Avoid deadlocks in tests when waiting expectations
@laevandus laevandus closed this May 20, 2024
auto-merge was automatically disabled May 20, 2024 07:02

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laevandus @Stream-iOS-Bot @testableapple @martinmitrevski