Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base resource requests on actual usage #2540

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented May 10, 2024

Background

  • This fixes Base CPU/Memory Requests on Actual Usage #591.
  • I looked at a deployment of Online Boutique from 4 days ago. I noted the max (actually used) vCPU and memory values of each microservice — within the full 4 days. (The deployment included the loadgenerator.) Olivier did a similar analysis in 2022.
  • For each value, I rounded up to the next 10m (for CPU) and the next 10MiB for memory — to add a buffer.

Change Summary

  • I've updated the resource.requests.cpu and resource.requests.memory values of each default microservices's Deployment.

Testing Procedure

  • We just have to make sure the staging URL works fine. :)

Copy link

🚲 PR staged at http://34.42.127.234

@NimJay NimJay marked this pull request as ready for review May 10, 2024 23:47
@NimJay NimJay requested review from yoshi-approver and a team as code owners May 10, 2024 23:47
Copy link

🚲 PR staged at http://34.42.127.234

@NimJay NimJay marked this pull request as draft May 11, 2024 00:15
@NimJay NimJay added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 11, 2024
@NimJay NimJay marked this pull request as ready for review May 11, 2024 00:16
@NimJay NimJay removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 11, 2024
@NimJay
Copy link
Collaborator Author

NimJay commented May 13, 2024

I have tested the new Kubernetes manifests on the regular channel and rapid channel (see delete-me-test-resources-new and delete-me-test-resources-new-rapid below).
The new manifests work.
Screenshot 2024-05-13 at 11 32 42 AM

However, I believe, on GKE autopilot, this only shaved off 0.25 vCPUs because the Managed Service for Prometheus is enabled by default on GKE autopilot and requires a lot (relative to Online Boutique) of resources.

Screenshot 2024-05-13 at 11 34 52 AM
Screenshot 2024-05-13 at 11 36 30 AM

Copy link

🚲 PR staged at http://34.42.127.234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base CPU/Memory Requests on Actual Usage
1 participant