Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment button options (align to artboard) #1720

Open
Keavon opened this issue Apr 1, 2024 · 3 comments · May be fixed by #1724
Open

Alignment button options (align to artboard) #1720

Keavon opened this issue Apr 1, 2024 · 3 comments · May be fixed by #1724
Assignees
@nico-mayora
Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend

Comments

@Keavon
Copy link
Member

Keavon commented Apr 1, 2024

This popover menu is currently "coming soon".

image

We'd like to have a checkbox (off by default) called "To Artboard" which makes the alignment of all selected layers work in relation to the artboard rather than their collective bounding box.

There has also been a request for letting the user choose a specific layer's bounding box to align all other layers to (meaning that chosen layer doesn't move, but the others do).

Potentially one more feature that would be handy is a way to choose between "deep" and "shallow" treatment of nested layers, where only the selected folders get aligned vs. each of their contents get aligned.
@Keavon Keavon added Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend labels Apr 1, 2024
@nico-mayora
Copy link
Contributor

I can take this on. The checkbox UI element won't require any frontend coding, right?

@0HyperCube
Copy link
Member

No javascript required, the widgets are defined in select_tool.rs:174 @nico-mayora. An example of a checkbox in a popover widget is the snapping options defined in document_message_handler.rs:1147.

@nico-mayora nico-mayora linked a pull request Apr 5, 2024 that will close this issue
Draft
@nico-mayora
Copy link
Contributor

I think my PR is ready for review if anyone would give it a look :^) #1724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nico-mayora nico-mayora

Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend
Projects
Task Board
Status: Short-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add alignment buttons popover option for alignment relative to artboard nico-mayora/Graphite
3 participants
@Keavon @nico-mayora @0HyperCube