New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alignment buttons popover option for alignment relative to artboard #1724
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well apart from the broken checkbox.
8e48669
to
5596691
Compare
!build |
|
QA feedback:
|
I've pushed fixes for points 1 and 3, but can't manage to reproduce 2. Would you mind elaborating a bit more? |
wip feat: add aligning relative to a layer
|
What if the selection spans several artboards and "Preserve relative positions" is checked? |
Good question. Let's say it preserves relative positions of each per-artboard group of layers. |
Closes #1720.
This issue is still very much WIP--note the numerousdebug!
calls :^), but wanted to get this PR going as I have run into a small issue:Noteeditor/src/messages/tool/tool_messages/select_tool.rs:173
: I've made it so that ifto_artboard
istrue
, the alignment options are again enabled for just one selected object. In practise, this doesn't work--ticking the checkbox won't update the alignment buttons automatically. We need to reselect the object for the effect to take place. Is there a way this automatic refresh can be done?Solved!