-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New nodes: shape/curve primitives #1389
Conversation
Shouldn't 'Spline' be called 'Arc'? Or alternatively, take N inputs if that'd be possible. |
I think calling it a 'Arc' would be a bit misleading as you wouldn't really be able to use it in that mannar. As for the "N inputs", I was thinking of making that a seperate mode inside the node itself or making it into a seperate node entirely? Technically the 'Spline' node resembles the 'Quadratic Bezier' node in Blender |
I can't imagine that this Spline node is all that useful all on its own, but the n-input Spline node likely would be useful (and would act as a superset, so your three-point use case is covered using it). I suggest changing it to support the n-input case. |
Yes, it would also allow the ( #1125 ) to be completed. Additionally I think it would be good to modify how the List Inputs currently function (Eg. Stroke Node -> Dashed Lengths ) to function similarly to how the Gradient Input functions, and ideally it would also be good to have an input that takes more than one input (Eg. Join Geometry Node) to make it easier to join Lists (And it would be useful for other types of nodes like the Vector Ops) |
Yes, that would be a good improvement! Feel free to implement that. Regarding the multi-input node connections, we should ask @TrueDoctor about any limitations his Graphene system design might impose. |
there is a graphene-idiomatic way to construct lists by basically using vertical compositing to chain together multiple push nodes which you could then feed into the list input. You could then of course hide the layer stack to reduce visual clutter and in general design abstractions which hide this from the user, but that is what has to happen in the backend. |
3ae78c3
to
f05c647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well - I'm excited to see these integrated into the tools.
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs
Outdated
Show resolved
Hide resolved
c6edfea
to
7919d98
Compare
Part of #912
New Nodes: