New node: Color Overlay #1391
Merged
New node: Color Overlay #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
approved these changes
Aug 24, 2023
...src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
Outdated
Show resolved
Hide resolved
0HyperCube
reviewed
Aug 24, 2023
0HyperCube
reviewed
Aug 24, 2023
Keavon
force-pushed
the
master
branch
4 times, most recently
from
961e007
to
314ce05
Compare
- this needs to accommodate coloring the image
- correct the node implementation logic -[wip]use node in Color Overlay node network
- rename ColorFillNode node to Color Fill - remove unneeded clone method call
- fix broken color fill implementation logic - add alpha multiplication data to the image
Keavon
approved these changes
Sep 2, 2023
Keavon
approved these changes
Sep 2, 2023
Keavon
added a commit
that referenced
this pull request
Sep 2, 2023
* [wip]feat: implement Color Overlay node's base logic * [wip]feat: attempt implementing node * feat: implement naive node logic - this needs to accommodate coloring the image * [wip]feat: attempt implementing ColorFillNode * fix: color fill node implementation path * Simplify document node definition * [wip]feat: implement ColorFillNode - correct the node implementation logic -[wip]use node in Color Overlay node network * Remove secondary image input * chore: perform cleanup and minor optimization - rename ColorFillNode node to Color Fill - remove unneeded clone method call * refactor: optimize node logic and hide optional params * fix: color fill implementation - fix broken color fill implementation logic - add alpha multiplication data to the image * Fix colour overlay node * Blend mode * chore: remove unused import * Debug logging for overlay * Use premultiplied alpha * Comment out logging * Code review nits * Remove color debug logging --------- Co-authored-by: Dennis Kobert <dennis@kobert.dev> Co-authored-by: 0hypercube <0hypercube@gmail.com> Co-authored-by: Keavon Chambers <keavon@keavon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add the Color Overlay node that will overlay a color on top while preserving the original image's alpha value.
Part of #912