-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running agent.arun(input=df) with environment=None is totally valid. #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Although I totally agree with your proposal, it is still interesting how do you specifically use async call without async environment? It would be great if you could provide an example code so we would incorporate it in our future tutorials
Thank you, and I look forward to having this merged. I can't provide an example code, unfortunately, but the code we're writing is based on the Two reasons for this:
That said, I always thought that an |
Hi, is there anything else required to merge this PR? |
@niklub Please, could you merge this PR? |
Any news? |
Hi, ping about this PR - it's really simple |
a404bcd
to
d9f7e73
Compare
Otherwise this code requires us to create an dummy async environment which is not used in the code and not even possible with the current code base.
5448e37
to
06744f3
Compare
@niklub @matt-bernstein Any chance this can be merged? |
Thanks for the nudge here. Appreciate not letting this one fall through the cracks. 🙂 |
Otherwise this code requires us to create an dummy async environment which is not used in the code and not even possible with the current code base.