Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved TODO in tokenize_ftdp_datasets.py #580

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Resolved TODO in tokenize_ftdp_datasets.py #580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af6be1
resolved1TODO
Apr 17, 2024
e52e5d1
Merge branch 'main' into main
neverbiasu Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions xtuner/tools/tokenize_ftdp_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ def format_sub_role(messages: List[Dict], roles_cfg) -> List[Dict]:
for dialog_item in _processed_data:
role = dialog_item['role']
content = dialog_item['content']
# TODO: is strip necessary? or use lstrip? 避免开始有\n\n的情况
# content = content.lstrip()
# Resolved TODO: Used lstrip to remove leading newline characters from content
content = content.lstrip('\n')
begin = format_begin(role_cfg[role], dialog_item)
end = role_cfg[role]['end']
begin_token = tokenizer.encode(begin, add_special_tokens=False)
Expand Down