Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic open/save functionality (revised) #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tinyg
Copy link

@tinyg tinyg commented Jul 23, 2023

Port nobecutan's changes from "Basic open/save functionality" to the latest version of Boop and then make the errors show in the status view.

Original pull request comments:

With this merge request I propose basic file handling functionality. Open any file type and try to parse it as String via String(contentsOf: pathUrl) – silently ignore the file if it cannot be parsed. This works also via CMD+O and by dragging the file on the app icon.
This addresses #256 and #227.

Save the content as file (via CMD+SHIFT+S). There is no notion of an open file, it's always "Save As…".
This addresses #278.

Port nobecutan's changes to the latest version of Boop and then make the errors show in the status view.
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@luckman212
Copy link

This would be an awesome merge! ✨

I'd love to be able to set Boop as my default handler for the public.json UTI for quick manipulation of JSON files.

@JanStorm
Copy link

I just compiled your version of the code. Seems that this breaks the editor.
In my case (Macbook Pro M1 Max) the line numbers were on the right and i cannot see any text i tried to write:
Bildschirmfoto 2024-04-24 um 14 53 21
(But its somehow there, because when pressing enter, the line numbers increases, feels like the editor moved to the right, out the window)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants