Properly set header fields in ZipArchiveOutputStream #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File names are written in UTF-8, so bit 11 (language encoding flag) of the general purpose bit flag must be set in both local file headers and central directory entries. Other zip implementations (e.g. zipinfo, or python's zipfile library) also require other header fields (version requried to extract, version made by) to be set to reasonable values in order to correctly interpret UTF-8 names, so set these as well. Also set file permissions in the 'external file attributes' central directory entry field to rw-r--r--.
File names are written in UTF-8, so bit 11 (language encoding flag) of the general purpose bit flag must be set in both local file headers and central directory entries. Other zip implementations (e.g. zipinfo, or python's zipfile library) also require other header fields (version requried to extract, version made by) to be set to reasonable values in order to correctly interpret UTF-8 names, so set these as well. Also set file permissions in the 'external file attributes' central directory entry field to -rw-r--r-- for files and drwxr-xr-x for directories..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names are written in UTF-8, so bit 11 (language encoding flag) of the general purpose bit flag must be set in both local file headers and central directory entries.
Other zip implementations (e.g. zipinfo, or python's zipfile library) also require other header fields (version requried to extract, version made by) to be set to reasonable values in order to correctly interpret UTF-8 names, so set these as well.
Also set file permissions in the 'external file attributes' central directory entry field to rw-r--r--.