[kotlin] J2K: Add JKTree processing step to remove redundant type projections #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermattt
commented
Apr 22, 2024
| @@ -1,4 +1,4 @@ | |||
| internal interface INode | |||
| internal interface Node | |||
| internal open class A | |||
| internal class CC<T, K> : A() where T : INode?, T : Comparable<T?>?, K : Node?, K : Collection<K?>? | |||
There was a problem hiding this comment.
IMO the nullability change on T is good--I think removing the out/in earlier allows some of the nullability postprocessing steps to function at their best, since it's still T? before any postprocessing steps run (see attached screenshot). That being said, maybe I'm missing some important cases where it should stay nullable?
abelkov
requested changes
Apr 29, 2024
...ns/kotlin/j2k/shared/tests/testData/newJ2k/detectProperties/GetterWithRedundantProjection.kt
Outdated
Show resolved
Hide resolved
ermattt
force-pushed
the
03-29-add_more_test_cases_for_redundant_type_projection
branch
from
e0cc347
to
2c7112a
Compare
ermattt
force-pushed
the
03-29-add_more_test_cases_for_redundant_type_projection
branch
from
2c7112a
to
e97c90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spreadsheet, this one is listed as "REDUNDANT_PROJECTION."
Unfortunately this JKTree processing step isn't sufficient to remove the corresponding diagnostic-based postprocessing step: we need mutability analysis to run before we can remove redundant type projections from collections' type parameters (e.g. we can't remove the
outfromMutableList<out Foo>, but we can fromList<out Foo>). If I omit the postprocessing step, there are 8 failing K1 tests (see attached screenshot).I also tried implementing these changes by modifying JavaToJKTreeBuilder, but that had a bunch of unpleasant side effects, and didn't seem like a natural place to stick this logic.
NB: The test cases added here are largely based on my imagination, and might be overkill.
@abelkov @darthorimar @jocelynluizzi13