-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the IJP Gradle Plugin 2.0 #1301
Conversation
My opinion:
+1; it would be nice to explain the purpose.
I think we should use more concise form, so "Prints the list..." instead of "This task prints the list...". This style is used in, e.g., method Javadocs, which I think are analogical to task descriptions on our pages.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (two minors).
...ppendix/tools/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_tasks.md
Outdated
Show resolved
Hide resolved
...ppendix/tools/intellij_platform_gradle_plugin/tools_intellij_platform_gradle_plugin_tasks.md
Outdated
Show resolved
Hide resolved
…tellij_platform_gradle_plugin_tasks.md Co-authored-by: Karol Lewandowski <karol.lewandowski@jetbrains.com>
Please note that some texts need to be synced with kdoc in the plugin itself. |
Thanks! |
Some things to discuss so far:
showPaidPluginWarning
description does not explain why this is needed. It just explains what it does, which everyone can guess from the name already.verifyPluginConfiguration
Is it correct that this task validates that "The currently selected Java Runtime is not JetBrains Runtime (JBR)"?