Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Outline not working locally #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hustf
Copy link
Contributor

@hustf hustf commented Oct 13, 2023

This is not working locally. It's probably a good idea to try this out on another operating system than mine.

Three unresolved reasons for taking a break locally right now. I still think this is a good idea, though:

  1. It is unclear to me whether [deps] sholud include the projects from [weakdeps] when we do not require Julia < 1.9.
    I tried to remove the [deps] entry for LaTextStrings and Mathexengine (previous PR). But that did not seem to work.

  2. FFMPEG won't fully install on my computer. Possible reason explained in FFMPEG issue. If Luxor is CI tested on Windows, we would probably need to modify the script. And the important point is that Luxor starts working better on Windows computers without those special codecs.

  3. I'm struggling with this Julia issue, too, which I'm meeting. I believe it has to do with the package registry and showing differences.

    modified: Project.toml
    new file: ext/LuxorExtFFMPEG.jl
    new file: ext/creategif.jl
    modified: src/animate.jl
    modified: src/placeholders_for_extensions.jl

	modified:   Project.toml
	new file:   ext/LuxorExtFFMPEG.jl
	new file:   ext/creategif.jl
	modified:   src/animate.jl
	modified:   src/placeholders_for_extensions.jl
@cormullion
Copy link
Member

Label this WIP for now?

@hustf
Copy link
Contributor Author

hustf commented Oct 13, 2023

Yes, but not sure I can label things even when I'm on a computer.

@cormullion cormullion changed the title Outline not working locally WIP : Outline not working locally Oct 13, 2023
@hustf
Copy link
Contributor Author

hustf commented Feb 10, 2024

Note for when I / we pick this up: Julia issue 3327 fixed in 3591 and the fix was included from Julia 1.9.4.

Copy link

stale bot commented Apr 22, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants