Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db/schema): do not allow setting priority with traditional route in mixed mode #13021

Merged
merged 4 commits into from
May 20, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented May 13, 2024

Summary

Notice: regex_priority and priority have the default value 0, so we think 0 is equivalent to "not set".

KAG-4411

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/M and removed size/S labels May 13, 2024
@chronolaw chronolaw changed the title fix(db/schema): do not allow setting priority with traditional route fields in mixed mode fix(db/schema): do not allow setting priority with traditional route in mixed mode May 13, 2024
@chronolaw chronolaw changed the title fix(db/schema): do not allow setting priority with traditional route in mixed mode (db/schema): do not allow setting priority with traditional route in mixed mode May 14, 2024
@chronolaw chronolaw marked this pull request as ready for review May 14, 2024 02:14
@chronolaw chronolaw changed the title (db/schema): do not allow setting priority with traditional route in mixed mode feat(db/schema): do not allow setting priority with traditional route in mixed mode May 14, 2024
@dndx dndx merged commit d286b1c into master May 20, 2024
30 checks passed
@dndx dndx deleted the fix/route_priority_validation branch May 20, 2024 07:24
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

chronolaw added a commit that referenced this pull request May 28, 2024
ADD-SP pushed a commit that referenced this pull request May 28, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13021-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13021-to-master-to-upstream
git checkout -b cherry-pick-13021-to-master-to-upstream
ancref=$(git merge-base d112f3c09bf049fe4614dc5f38e45cba5adce0f7 9167936567c7ce285331a0aaf6e1ec9e23113b65)
git cherry-pick -x $ancref..9167936567c7ce285331a0aaf6e1ec9e23113b65

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label May 28, 2024
github-actions bot pushed a commit that referenced this pull request May 28, 2024
…ute in mixed mode (#13021)

`priority` has no meaning for traditional based routes, this PR adds additional validation check
to make sure these are detected at creation time to avoid causing confusions to the user.

KAG-4411

(cherry picked from commit d286b1c)
@team-gateway-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/3.7.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention schema-change-noteworthy size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants