feat(conf): add concurrency_timeout option #13027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
core/templates
core/configuration
cherry-pick kong-ee
outsinre
force-pushed
the
outsinre/FTI-5930-concurrency_timeout
branch
2 times, most recently
from
1c20977
to
d517383
Compare
outsinre
force-pushed
the
outsinre/FTI-5930-concurrency_timeout
branch
from
d517383
to
462f6e3
Compare
outsinre
force-pushed
the
outsinre/FTI-5930-concurrency_timeout
branch
3 times, most recently
from
952559a
to
f7f4afe
Compare
outsinre
force-pushed
the
outsinre/FTI-5930-concurrency_timeout
branch
2 times, most recently
from
c339c80
to
e6347e6
Compare
|
Is this PR ready for review? |
|
@chronolaw ready! |
chronolaw
reviewed
May 15, 2024
Sets the timeout (in ms) for which a concurrency job (e.g. declaractive reconfigure) should wait for mutex before giving up. After the timeout, Kong gateway would skip the job, and log an error message. If you happen to see "timeout acquiring ... lock" log entries, try to adjust this value accordingly. Please be careful that setting a large value might result in a long list of concurreny jobs in queue, which could overflow the queue. It is fine to timeout if a job is safe to be overriden by subsequent jobs, like declaractive reconfigure. Do not touch this option unless you clear about it.
outsinre
force-pushed
the
outsinre/FTI-5930-concurrency_timeout
branch
from
b73037f
to
1cf75d3
Compare
chronolaw
approved these changes
May 16, 2024
bungle
requested changes
May 17, 2024
bungle
requested changes
May 17, 2024
| -- Is it worth to have node level mutex instead? | ||
| -- If so, the RETRY_LRU also needs to be node level. | ||
| concurrency.with_coroutine_mutex({ | ||
| name = name, | ||
| timeout = ROTATION_INTERVAL, | ||
| timeout = concurrency_timeout, |
There was a problem hiding this comment.
Changes timeout without changing rotation interval used elsewhere. Removes the link between then.
|
Let's leave this to customers as usually a job takes shorter than 60s. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat(conf): add concurrency_timeout option
Sets the timeout (in ms) for which a concurrency
job (e.g. declaractive reconfigure) should wait
for mutex before giving up. After the timeout,
Kong gateway would skip the job, and log an error
message.
If you happen to see "timeout acquiring ... lock"
log entries, try to adjust this value accordingly.
Please be careful that setting a large value might
result in a long list of concurreny jobs in queue,
which could overflow the queue.
It is fine to timeout if a job is safe to be
overriden by subsequent jobs, like declaractive
reconfigure. Do not touch this option unless you
clear about it.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #FTI-5930 #[KAG-4480]