Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro config routes & UI #339

Draft
wants to merge 36 commits into
base: dev
Choose a base branch
from
Draft

Macro config routes & UI #339

wants to merge 36 commits into from

Conversation

C0W0
Copy link
Member

@C0W0 C0W0 commented Aug 22, 2023

Description

  • Added routes for the front end to call to trigger config parsing and obtain the configs of a macro
  • Also fixed the description parsing - now empty lines at the beginning of the description will no longer result in padding spaces.
  • Added frontend UI calling the backend routes for parsing & generating the macro config
    image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Note: make sure your files are formatted with rust-analyzer

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for lodestone-dashboard canceled.

Name Link
🔨 Latest commit b2b5a9d
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/6653c29b452d0a0008ba95c4

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for lodestone-storybook canceled.

Name Link
🔨 Latest commit b2b5a9d
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/6653c29b37ed740008f2288b

@C0W0 C0W0 requested a review from CheatCod August 25, 2023 22:37
@C0W0 C0W0 self-assigned this Aug 27, 2023
@C0W0 C0W0 marked this pull request as draft August 30, 2023 18:02
@C0W0 C0W0 changed the title Macro config routes Macro config routes & UI May 19, 2024
Copy link
Member

@CheatCod CheatCod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dropdown is not scrollable
image

Another problem: the frontend crashes when trying to edit the config or the following:

class LodestoneConfig {
    // the id of the instance
    id: number = 1;
    /**
     * the location of the backups
     */
    backupType: 'local' | 'online' | 'disabled' | 'test1' | 123123 = 'local';
    allowDuplicates: boolean = true;
}
image

Copy link
Member

@CheatCod CheatCod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class LodestoneConfig {
    // the id of the instance
    id: number = 1;
    /**
     * the location of the backups
     */
    backupType: 'local' | 'test' = random junk;
    allowDuplicates: boolean = true;
}

Causes backend to panic when constructing a SettingManfiest, which drops the request from the frontend and causes a network error:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants