refactor(bootstrap): improve stdpath override #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opalmay
changed the title
kylo252
reviewed
Feb 25, 2023
| end | ||
| return vim.call("stdpath", what) | ||
| end | ||
|
|
||
| vim.api.nvim_call_function = function(fn, args) |
There was a problem hiding this comment.
is this function commonly used? or is it for covering all the basis? I'm not sure it's worth it if it's the latter, since there are quite a few ways that can still access these values.
Comment on lines
+73
to
+74
| -- elseif what == "data" then | ||
| -- return _G.get_runtime_dir() |
There was a problem hiding this comment.
Suggested change
| -- elseif what == "data" then | |
| -- return _G.get_runtime_dir() |
| @@ -64,15 +64,25 @@ function M:init(base_dir) | |||
| self.lazy_install_dir = join_paths(self.pack_dir, "lazy", "opt", "lazy.nvim") | |||
|
|
|||
| ---@meta overridden to use LUNARVIM_CACHE_DIR instead, since a lot of plugins call this function internally | |||
| ---NOTE: changes to "data" are currently unstable, see #2507 | |||
There was a problem hiding this comment.
we should keep this note 🥲
| ---@diagnostic disable-next-line: duplicate-set-field | ||
| vim.fn.stdpath = function(what) | ||
| if what == "cache" then | ||
| return _G.get_cache_dir() | ||
| elseif what == "config" then |
There was a problem hiding this comment.
Don't forget to update the corresponding test, see https://github.com/LunarVim/LunarVim/pull/2540/files#diff-e02939ff80b05af32ad541b952d46570ab42ca3386e9eeab4bd4990955af4687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3855
As we are not going to deprecate not using $NVIM_APPNAME, this is still relevant.
I removed the
dataoverride so that it's not breaking. But at least things likeNullLsLogwill show correctly.