Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove non default colorschemes #4134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChristianChiarulli
Copy link
Member

No description provided.

@LostNeophyte
Copy link
Member

can we use #3700 instead? has a deprecation warning

Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @LostNeophyte, we should at least have a clear deprecation warning, and a fallback by checking if the plugin exists we already implement a fallback in #2982 馃槃 .

@cpea2506
Copy link
Member

cpea2506 commented May 22, 2023

Do we have a plan to replace lvim.colorscheme with this option in the future? So users won't have to call the field twice if they want to customize some options in the colorscheme like below:

lvim.colorscheme = "lunar"
lvim.builtin.theme = {
	name = "lunar"
	lunar = {
		options = {
			-- option values
		}
	}
}

The new theme setting can be a string or a table:

lvim.builtin.theme = "lunar"
-- or
lvim.builtin.theme = {
	name = "lunar"
	options = {
		-- option values
	}
}

or shorter name with only lvim.colorscheme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants