-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): migrate indent-blankline
to v3
#4427
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change, if a user edits buftype_exclude
or filetype_exclude
in their config, it will now cause an error. I'd set them to empty tables in _deprecated.lua and add a metatable with _index and _newindex set to a function that will notify the user of the change
in that case just set them to empty tables, unless that also triggers the warning, then we would need to set them to nil if they're empty before passing them to setup() |
Then in that case, user won't know that they have wrong key inside their config. |
unless they set them to empty tables which i doubt then they'll know. We'll only set them to nil the user left them empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it easier to keep the existing config for now and adapt it internally to the new layout? any new options can match the ones upstream.
otherwise, we need to "ignore" the old options but also warn with a deprecation message
I need a guides on how to handle this correctly. What I wonder for now are:
|
Description
Update indent-blankline to latest version 3.
Note: still not sure how to handle error message correctly and make it more understandable to users
How this has been test
A message will popup to indicate that you are using old config and require you to update to match new version.
Currently there is no specific message from original plugin on how to migrate config exactly.